Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_ipv6_nib: use generated EUI-64 for ARO build and check [backport 2019.01] #10906

Merged
merged 6 commits into from
Jan 30, 2019
Merged

gnrc_ipv6_nib: use generated EUI-64 for ARO build and check [backport 2019.01] #10906

merged 6 commits into from
Jan 30, 2019

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jan 30, 2019

Backport of #10817

Contribution description

This fixes #10723 by providing a new getter for the (unconverted) EUI-64 in the interface layer. This getter then is used instead of the link-layer address to set the EUI-64 in the ARO and also check it.

Testing procedure

Flash two 6Lo-capable boards with gnrc_border_router and gnrc_networking. The gnrc_networking should get a global address which will be marked as valid. Not just IEEE 802.15.4-capable boards should be able to do this now, but also BLE-based boards and more exotic candidates like cc110x, nrfmin, or esp-now.

Issues/PRs references

Closes #10723.

gnrc_netif/gnrc_sixlowpan_iphc BLE capability

@miri64 miri64 added Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Jan 30, 2019
@miri64 miri64 requested a review from cgundogan January 30, 2019 12:40
@miri64 miri64 mentioned this pull request Jan 30, 2019
Merged
aabadie
aabadie previously approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared changes against original PR (using git range-diff), no differences.

ACK

@aabadie
Copy link
Contributor

aabadie commented Jan 30, 2019

Ok, so the branch wasn't up-to-date with the base branch, so I pressed "Update branch" and this creates a merge commit. Would you mind rebasing the branch @miri64 (to drop the merge commit) ?

@cgundogan
Copy link
Member

I tested by merging on the devel branch and everything works as expected, btw. So also ACK

@cgundogan cgundogan added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jan 30, 2019
@miri64 miri64 force-pushed the backport/2019.01/gnrc_netif/enh/i10723 branch from b3c1ef9 to 9c8d70e Compare January 30, 2019 13:27
@miri64
Copy link
Member Author

miri64 commented Jan 30, 2019

Rebased.

aabadie
aabadie approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still no change, re-ACK (sorry, first time on wrong PR)

@aabadie aabadie merged commit 053c3d7 into RIOT-OS:2019.01-branch Jan 30, 2019
@miri64 miri64 deleted the backport/2019.01/gnrc_netif/enh/i10723 branch January 30, 2019 14:10
@aabadie aabadie added this to the Release 2019.01 milestone Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

Assignees
No one assigned
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2019.01
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @aabadie @cgundogan