Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefiles/modules.inc.mk: refactoring #11109

Merged
merged 5 commits into from
Mar 11, 2019
Merged

makefiles/modules.inc.mk: refactoring #11109

merged 5 commits into from
Mar 11, 2019

Commits on Mar 5, 2019

  1. makefiles/modules.inc.mk: do not export USEMODULE 

    USEMODULE is already exported by `makefiles/vars.inc.mk`.
    @cladmi
    cladmi committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    670a836 View commit details
    Browse the repository at this point in the history

  2. makefiles/modules.inc.mk: do not export BASELIBS 

    BASELIBS is used only in the main Makefile.include or included files.
As it is not used in sub make executions or scripts it does not need to
be exported.
    @cladmi
    cladmi committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    b6645b5 View commit details
    Browse the repository at this point in the history

  3. makefiles/modules.inc.mk: factorize in _ALLMODULES 

    Factorize the reused value in a private variable.

I define it private as somehow 'USEPKG' is supposed to be removed so the
variables can be removed later.
    @cladmi
    cladmi committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    c2b1995 View commit details
    Browse the repository at this point in the history

  4. makefiles/modules.inc.mk: group CFLAGS handling 

    Put all lines related to CFLAGS handling together.
    @cladmi
    cladmi committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    5453523 View commit details
    Browse the repository at this point in the history

  5. makefiles/modules.inc.mk: refactor, do not overwrite NO_PSEUDOMODULES 

    Refactor to define REALMODULES incrementally without overwriting
'NO_PSEUDOMODULES'.

This also allows an external makefile to maybe add something there if it really
needs to.
    @cladmi
    cladmi committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    8d58e3b View commit details
    Browse the repository at this point in the history