Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor text fix for mainpage.md #12802

Merged
merged 1 commit into from
Dec 1, 2019
Merged

Minor text fix for mainpage.md #12802

merged 1 commit into from
Dec 1, 2019

Conversation

jasdeepgill
Copy link
Contributor

Contribution description

Rearranged sentence so that only one 'and' is used in the sentence. Did the same for line
114.

Testing procedure

Issues/PRs references

@aabadie aabadie added Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Nov 25, 2019
aabadie
aabadie previously approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

This PR improves the sentence without removing any information. I allowed myself to push an update: there was a missing space before support and a trailing whitespace was added. I also updated the commit message.

@aabadie
Copy link
Contributor

aabadie commented Nov 27, 2019

How about

The kernel consists of the scheduler, inter-process-communication (messaging), threading, and thread
synchronization, as well as supporting data-structures and type definitions.

This is much better indeed. @jasdeepgill would you mind updating this PR accordingly ?

@aabadie aabadie dismissed their stale review November 27, 2019 17:55

Still need work

aabadie
aabadie approved these changes Nov 30, 2019
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now.

ACK

@jasdeepgill @aabadie
doc: minor text fix for mainpage.md
75770b5 
Rearranged sentence so that only one 'and' is used in the sentence
@aabadie aabadie merged commit df7c424 into RIOT-OS:master Dec 1, 2019
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 left review comments

@yegorich yegorich yegorich left review comments

@aabadie aabadie aabadie approved these changes

Assignees
No one assigned
Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.01
Development

Successfully merging this pull request may close these issues.
5 participants
@jasdeepgill @aabadie @miri64 @yegorich @fjmolinas