Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/esp32: fix C linkage compilation error #13141

Merged
merged 1 commit into from
Jan 16, 2020
Merged

cpu/esp32: fix C linkage compilation error #13141

merged 1 commit into from
Jan 16, 2020

Conversation

gschorcht
Copy link
Contributor

@gschorcht gschorcht commented Jan 16, 2020 •
edited
Loading

Contribution description

This PR fixes a C linkage compilation error with the new version of the ESP32 toolchain in RIOT-OS/riotdocker#97. The C linkage compilation error happens for example for examples/posix_socket and all applications that use esp_wifi or esp_now.

The reason for the C linking error was that drivers/include/mtd.h was included in boards/esp32/board_common.h within the external C block. This caused atomic_base.h to be included inside the external C block, which in turn caused the C linking error for the template definitions in that file, for example:

xtensa-esp32-elf/include/c++/5.2.0/bits/atomic_base.h:109:3: error: template with C linkage
   template<typename _Tp>

make RIOT_CI_BUILD=1 CC_NOCOLOR=1 --no-print-directory -C ./examples/posix_sockets clean all
Building application "posix_sockets_example" for "esp32-wroom-32" with MCU "esp32".

In file included from /home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:41:0,
                 from /home/gs/src/RIOT-Xtensa-ESP.git/sys/include/vfs.h:61,
                 from /home/gs/src/RIOT-Xtensa-ESP.git/drivers/include/mtd.h:28,
                 from /home/gs/src/RIOT-Xtensa-ESP.git/boards/common/esp32/include/board_common.h:106,
                 from /home/gs/src/RIOT-Xtensa-ESP.git/boards/esp32-wroom-32/include/board.h:65,
                 from /home/gs/src/RIOT-Xtensa-ESP.git/cpu/esp32/include/sdk_conf.h:31,
                 from /home/gs/src/RIOT-Xtensa-ESP.git/cpu/esp32/vendor/esp-idf/include/spi_flash/esp_spi_flash.h:22,
                 from /home/gs/src/RIOT-Xtensa-ESP.git/cpu/esp32/vendor/esp-idf/nvs_flash/nvs_page.hpp:23,
                 from /home/gs/src/RIOT-Xtensa-ESP.git/cpu/esp32/vendor/esp-idf/nvs_flash/nvs_page.cpp:14:
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/bits/atomic_base.h:109:3: error: template with C linkage
   template<typename _Tp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/bits/atomic_base.h:119:3: error: template with C linkage
   template<typename _IntTp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/bits/atomic_base.h:125:3: error: template with C linkage
   template<typename _Tp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/bits/atomic_base.h:128:3: error: template with C linkage
   template<typename _Tp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/bits/atomic_base.h:237:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/bits/atomic_base.h:564:3: error: template with C linkage
   template<typename _PTp>
   ^
In file included from /home/gs/src/RIOT-Xtensa-ESP.git/sys/include/vfs.h:61:0,
                 from /home/gs/src/RIOT-Xtensa-ESP.git/drivers/include/mtd.h:28,
                 from /home/gs/src/RIOT-Xtensa-ESP.git/boards/common/esp32/include/board_common.h:106,
                 from /home/gs/src/RIOT-Xtensa-ESP.git/boards/esp32-wroom-32/include/board.h:65,
                 from /home/gs/src/RIOT-Xtensa-ESP.git/cpu/esp32/include/sdk_conf.h:31,
                 from /home/gs/src/RIOT-Xtensa-ESP.git/cpu/esp32/vendor/esp-idf/include/spi_flash/esp_spi_flash.h:22,
                 from /home/gs/src/RIOT-Xtensa-ESP.git/cpu/esp32/vendor/esp-idf/nvs_flash/nvs_page.hpp:23,
                 from /home/gs/src/RIOT-Xtensa-ESP.git/cpu/esp32/vendor/esp-idf/nvs_flash/nvs_page.cpp:14:
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:52:3: error: template with C linkage
   template<typename _Tp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:57:3: error: template specialization with C linkage
   template<>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:164:3: error: template with C linkage
   template<typename _Tp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:319:3: error: template with C linkage
   template<typename _Tp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:509:3: error: template specialization with C linkage
   template<>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:528:3: error: template specialization with C linkage
   template<>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:547:3: error: template specialization with C linkage
   template<>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:566:3: error: template specialization with C linkage
   template<>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:585:3: error: template specialization with C linkage
   template<>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:604:3: error: template specialization with C linkage
   template<>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:623:3: error: template specialization with C linkage
   template<>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:642:3: error: template specialization with C linkage
   template<>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:661:3: error: template specialization with C linkage
   template<>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:680:3: error: template specialization with C linkage
   template<>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:699:3: error: template specialization with C linkage
   template<>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:718:3: error: template specialization with C linkage
   template<>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:737:3: error: template specialization with C linkage
   template<>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:756:3: error: template specialization with C linkage
   template<>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic: In function 'bool std::atomic_flag_test_and_set_explicit(volatile std::atomic_flag*, std::memory_order)':
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:898:27: error: conflicting declaration of C function 'bool std::atomic_flag_test_and_set_explicit(volatile std::atomic_flag*, std::memory_order)'
         memory_order __m) noexcept
                           ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:892:3: note: previous declaration 'bool std::atomic_flag_test_and_set_explicit(std::atomic_flag*, std::memory_order)'
   atomic_flag_test_and_set_explicit(atomic_flag* __a,
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic: In function 'void std::atomic_flag_clear_explicit(volatile std::atomic_flag*, std::memory_order)':
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:907:27: error: conflicting declaration of C function 'void std::atomic_flag_clear_explicit(volatile std::atomic_flag*, std::memory_order)'
         memory_order __m) noexcept
                           ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:902:3: note: previous declaration 'void std::atomic_flag_clear_explicit(std::atomic_flag*, std::memory_order)'
   atomic_flag_clear_explicit(atomic_flag* __a, memory_order __m) noexcept
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic: In function 'bool std::atomic_flag_test_and_set(volatile std::atomic_flag*)':
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:915:55: error: conflicting declaration of C function 'bool std::atomic_flag_test_and_set(volatile std::atomic_flag*)'
   atomic_flag_test_and_set(volatile atomic_flag* __a) noexcept
                                                       ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:911:3: note: previous declaration 'bool std::atomic_flag_test_and_set(std::atomic_flag*)'
   atomic_flag_test_and_set(atomic_flag* __a) noexcept
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic: In function 'void std::atomic_flag_clear(volatile std::atomic_flag*)':
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:923:48: error: conflicting declaration of C function 'void std::atomic_flag_clear(volatile std::atomic_flag*)'
   atomic_flag_clear(volatile atomic_flag* __a) noexcept
                                                ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:919:3: note: previous declaration 'void std::atomic_flag_clear(std::atomic_flag*)'
   atomic_flag_clear(atomic_flag* __a) noexcept
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic: At global scope:
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:928:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:933:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:938:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:943:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:948:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:954:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:960:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:965:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:971:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:977:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:983:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:991:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:999:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1007:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1016:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1021:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1026:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1031:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1036:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1041:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1046:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1056:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1066:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1076:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1090:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1096:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1102:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1108:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1114:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1120:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1126:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1132:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1138:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1144:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1150:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1155:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1160:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1165:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1170:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1175:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1180:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1185:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1190:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1195:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1202:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1208:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1214:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1219:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1224:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1230:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1236:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/tmp/crosstool-NG/builds/xtensa-esp32-elf/xtensa-esp32-elf/include/c++/5.2.0/atomic:1241:3: error: template with C linkage
   template<typename _ITp>
   ^
/home/gs/src/RIOT-Xtensa-ESP.git/Makefile.base:121: recipe for target '/home/gs/src/RIOT-Xtensa-ESP.git/examples/posix_sockets/bin/esp32-wroom-32/esp_idf_nvs_flash/nvs_page.o' failed
make[5]: *** [/home/gs/src/RIOT-Xtensa-ESP.git/examples/posix_sockets/bin/esp32-wroom-32/esp_idf_nvs_flash/nvs_page.o] Error 1
/home/gs/src/RIOT-Xtensa-ESP.git/Makefile.base:29: recipe for target 'ALL--/home/gs/src/RIOT-Xtensa-ESP.git/cpu/esp32/vendor/esp-idf/nvs_flash' failed
make[4]: *** [ALL--/home/gs/src/RIOT-Xtensa-ESP.git/cpu/esp32/vendor/esp-idf/nvs_flash] Error 2
/home/gs/src/RIOT-Xtensa-ESP.git/Makefile.base:29: recipe for target 'ALL--/home/gs/src/RIOT-Xtensa-ESP.git/cpu/esp32/vendor/esp-idf' failed
make[3]: *** [ALL--/home/gs/src/RIOT-Xtensa-ESP.git/cpu/esp32/vendor/esp-idf] Error 2
/home/gs/src/RIOT-Xtensa-ESP.git/Makefile.base:29: recipe for target 'ALL--/home/gs/src/RIOT-Xtensa-ESP.git/cpu/esp32/vendor' failed
make[2]: *** [ALL--/home/gs/src/RIOT-Xtensa-ESP.git/cpu/esp32/vendor] Error 2
/home/gs/src/RIOT-Xtensa-ESP.git/Makefile.base:29: recipe for target 'ALL--/home/gs/src/RIOT-Xtensa-ESP.git/cpu/esp32' failed
make[1]: *** [ALL--/home/gs/src/RIOT-Xtensa-ESP.git/cpu/esp32] Error 2
/home/gs/src/RIOT-Xtensa-ESP.git/examples/posix_sockets/../../Makefile.include:540: recipe for target '/home/gs/src/RIOT-Xtensa-ESP.git/examples/posix_sockets/bin/esp32-wroom-32/application_posix_sockets_example.a' failed
make: *** [/home/gs/src/RIOT-Xtensa-ESP.git/examples/posix_sockets/bin/esp32-wroom-32/application_posix_sockets_example.a] Error 2

Return value: 2

Testing procedure

Compilation in Murdock should succeed with current ESP32 toolchain.

Issues/PRs references

Prerequisite for RIOT-OS/riotdocker#97
Part of the fix of issue #13133

@gschorcht
cpu/esp32: fix C linkage compilatio error
416e8ce 
With the new toolchain version required to fix issue RIOT-OS#13133, the compilation of `examples/posix_socket` fails due to a C linkage error in `atomic_base.h`. The reason is that including `drivers/include/mtd.h` in `boards/esp32/board_common.h` inside the `extern C` block finally leads to including `atomic_base.h` inside the `extern C` block which in turn to the C linkage error for the template definitions in this file.
@gschorcht gschorcht mentioned this pull request Jan 16, 2020
Merged
@gschorcht gschorcht added Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Jan 16, 2020
@kaspar030 kaspar030 mentioned this pull request Jan 16, 2020
Closed
5 tasks
kaspar030
kaspar030 approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Explanation makes sense, change is small. Murdock compiles fine.

@kaspar030 kaspar030 merged commit c4877c6 into RIOT-OS:master Jan 16, 2020
@gschorcht
Copy link
Contributor Author

@kaspar030 Thanks for merging.

@gschorcht
Copy link
Contributor Author

@fjmolinas This PR has to be backported even though the new ESP32 toolchain in RIOT-OS/riotdocker#97 won't be deployed for this release.

@gschorcht gschorcht deleted the cpu/esp32/fix_c_linkage branch January 16, 2020 14:39
@fjmolinas fjmolinas mentioned this pull request Jan 16, 2020
Merged
@fjmolinas
Copy link
Contributor

Backport provided in #13144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gschorcht @fjmolinas @kaspar030