Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/cortexm: move CPU_ARCH/FAM to Makefile.features #13392

Merged
merged 1 commit into from
Feb 18, 2020
Merged

cpu/cortexm: move CPU_ARCH/FAM to Makefile.features #13392

merged 1 commit into from
Feb 18, 2020

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Feb 17, 2020

Contribution description

This PR moves CPU_ARCH/CPU_FAM variables defined for cortexm CPUs from Makefile.include to Makefile.features.

This allows for determining earlier if some CortexM sub-architectures provides low-level features, such FPU or MPU.

The efm32 were already updated this way in #13174.
The kinetis family is not adapted yet because it needs more work. This can be done in follow-up PRs.

Testing procedure

  • A green Murdock should be ok

Issues/PRs references

Required by ##13391 and #13236. Also related to #9913.

@aabadie aabadie added Area: build system Area: Build system Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: cpu Area: CPU/MCU ports labels Feb 17, 2020
@aabadie aabadie mentioned this pull request Feb 17, 2020
Merged
benpicco
benpicco approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Murdock is happy and this just moves code around.

@aabadie aabadie merged commit 2c0afaa into RIOT-OS:master Feb 18, 2020
@aabadie aabadie deleted the pr/cpu/cpu_arch_features branch February 18, 2020 10:05
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.04
Development

Successfully merging this pull request may close these issues.
3 participants
@aabadie @benpicco @leandrolanzieri