Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix DNS resolution in ping6 #13450

Merged
merged 5 commits into from
Feb 24, 2020
Merged

fix DNS resolution in ping6 #13450

merged 5 commits into from
Feb 24, 2020

Commits on Feb 24, 2020

  1. sock_dns: fix off-by-one error in _parse_dns_reply()

    @benpicco
    benpicco committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    e9a4093 View commit details
    Browse the repository at this point in the history

  2. shell/gnrc_icmpv6_echo: set success state if DNS query succeeded 

    We need to set `res` to 0 to signal success, otherwise we end up
in the print usage case.
    @benpicco
    benpicco committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    a65daf7 View commit details
    Browse the repository at this point in the history

  3. shell/gnrc_icmpv6_echo: don't do DNS lookup for plain IP 

    When using ping6 with an IP address, don't do a DNS lookup.
Hostnames can't contain ':', so use that to tell them apart
from plain IP addressees.
    @benpicco
    benpicco committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    367f19d View commit details
    Browse the repository at this point in the history

  4. sock_dns: use the same buffer for request & reply 

    Saving RAM is more important than saving a few cycles
used by re-creating the request buffer in the error case.

Also reduce the size of the buffer to 128 bytes.
If we are just requesting the AAAA record it is unlikely
for the reply to take up the maximum size of 512 bytes.

We were already placing restrictions on the domain name length,
those are now actually a bit more relaxed (112 bytes instead of 64)
    @benpicco
    benpicco committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    1de1493 View commit details
    Browse the repository at this point in the history

  5. sock_dns: make sock_dns_query() return the length of the address 

    The implementation already did that, now also reflect this in the
documentation.
    @benpicco
    benpicco committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    fa44472 View commit details
    Browse the repository at this point in the history