Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/pinetime: update mtd_spi_nor config #13481

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

kaspar030
Copy link
Contributor

@kaspar030 kaspar030 commented Feb 26, 2020

Contribution description

#13332 changed the nor configuration, but was not CI checked after merging the pinetime configuration (using old format). This PR updates that configuration, fixing master compilation for the PineTime.

Testing procedure

Build anything for pinetime using mtd, e.g., tests/pkg_littlefs. Broken on master, working with this PR.

Issues/PRs references

#13332

@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports labels Feb 26, 2020
@kaspar030 kaspar030 requested a review from bergzand February 26, 2020 09:02
@kaspar030 kaspar030 requested a review from benpicco February 26, 2020 09:08
@kaspar030
Copy link
Contributor Author

Thanks @benpicco!

Copy link
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, tested with examples/filesystem. Thanks for fixing @kaspar030

@bergzand bergzand merged commit dde0535 into RIOT-OS:master Feb 26, 2020
@kaspar030 kaspar030 deleted the fix_pinetime_nor branch February 26, 2020 09:32
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants