drivers/ethos: use luid_get_eui48() #13944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the MAC address of the border router was entirely random. That meant that as a DHCPv6 client it would get a new prefix with every reboot. Due to RIOT-OS#12210 the nodes will never use the new address. Fix this by using luid_get_eui48() which will always return the same address across reboots. It also makes the code simpler.
benpicco
added
Type: enhancement
miri64
reviewed
Apr 24, 2020
There was a problem hiding this comment.
LGTM. @kaspar030 AFAIR the only reason it uses a random address, is because the luid mechanism did not exist back than, right?
miri64
added
Reviewed: 2-code-design
cgundogan
added
CI: ready for build
yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Previously the MAC address of the border router was entirely random.
That meant that as a DHCPv6 client it would get a new prefix with every reboot.
Due to #12210 the nodes will never use the new address.
Fix this by using
luid_get_eui48()which will always return the same address across reboots.It also makes the code simpler.
Testing procedure
examples/gnrc_border_routerwith the default options (UPLINK=ethos).ifconfigto view the address of the upstream interface.rebootthe border routerifconfig.On
master, the upstream interface will have a different address with each reboot.This fixes that.
Issues/PRs references