Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_sixlowpan_frag_vrb: fix cppcheck warning #14683

Merged
merged 1 commit into from
Aug 3, 2020
Merged

gnrc_sixlowpan_frag_vrb: fix cppcheck warning #14683

merged 1 commit into from
Aug 3, 2020

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Aug 3, 2020

Contribution description

... which wasn't a false positive after all. See also #12848 (review)

Testing procedure

make -C tests/gnrc_sixlowpan_iphc_w_vrb flash test

and

make -C tests/unittests tests-gnrc_sixlowpan_frag_vrb flash-only test

should still succeed for any supported board of choice.

Issues/PRs references

See #12848 (review)

@miri64
gnrc_sixlowpan_frag_vrb: fix cppcheck warning
5885293 
... which wasn't a false positive after all.
@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Aug 3, 2020
@miri64 miri64 added this to the Release 2020.10 milestone Aug 3, 2020
@miri64 miri64 mentioned this pull request Aug 3, 2020
Merged
keestux
keestux approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@keestux keestux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me

@miri64 miri64 merged commit b043e1f into RIOT-OS:master Aug 3, 2020
@miri64 miri64 deleted the gnrc_sixlowpan_frag_vrb/fix/cppcheck-warning branch August 3, 2020 11:16
@miri64 miri64 mentioned this pull request Aug 3, 2020
Merged
@miri64
Copy link
Member Author

miri64 commented Aug 3, 2020

Backport provided in #14686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keestux keestux keestux approved these changes

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@cgundogan cgundogan Awaiting requested review from cgundogan

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

Assignees
No one assigned
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2020.10
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @keestux