core: remove kernel_types.h #15482
Merged
core: remove kernel_types.h #15482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspar030
added
Area: core
kaspar030
requested review from
aabadie,
basilfx,
bergzand,
cgundogan,
fjmolinas,
haukepetersen,
leandrolanzieri,
MichelRottleuthner,
miri64,
MrKevinWeiss,
PeterKietzmann and
smlng
as code owners
|
Let's see what CI uncovers. |
kaspar030
added
the
State: waiting for other PR
turns out it is not that simple. :/ |
kaspar030
added
the
State: WIP
kaspar030
force-pushed
the
remove_kernel_types
branch
from
b60b1ed
to
a9cebc1
Compare
benpicco
added
CI: ready for build
kaspar030
force-pushed
the
remove_kernel_types
branch
from
b5ec314
to
be41fe4
Compare
benpicco
reviewed
Nov 25, 2020
| diff --git a/src/ccnl-core/include/ccnl-if.h b/src/ccnl-core/include/ccnl-if.h | ||
| index cf90dcf9c3..40d461a55e 100644 | ||
| --- a/src/ccnl-core/include/ccnl-if.h | ||
| +++ b/src/ccnl-core/include/ccnl-if.h |
There was a problem hiding this comment.
please also provide an upstream pr :)
benpicco
reviewed
Nov 25, 2020
benpicco
reviewed
Nov 25, 2020
benpicco
reviewed
Nov 25, 2020
|
I fixed the extra newlines. |
benpicco
approved these changes
Nov 25, 2020
Automatically removed using:
$ git grep -l kernel_types | xargs sed -i '/^#include .kernel_types/d'
Removal of kernel_types.h make these necessary.
kaspar030
force-pushed
the
remove_kernel_types
branch
from
6d46165
to
bc34c85
Compare
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR removes core/include/kernel_types.h, which seems to only contain obsolete info.
Another commit removes any includes of that file.
This also pointed to a missing include for inttypes.h in sched.h, which is added in another commit.moved to #15481.Testing procedure
Successful CI should be sufficient.
Issues/PRs references
Follow-up of #14787