congure_quic: initial import of QUIC congestion control #15952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Type: new feature
miri64
requested review from
aabadie,
cgundogan,
fjmolinas,
jia200x,
leandrolanzieri,
MichelRottleuthner and
smlng
as code owners
|
Maybe @larseggert also wants to take a look. |
miri64
force-pushed
the
congure/feat/congure_quic
branch
2 times, most recently
from
7a11318
to
3b5f6ca
Compare
miri64
force-pushed
the
congure/feat/congure_quic
branch
from
3b5f6ca
to
485b887
Compare
|
Rebased to current master, needs some adaptions to the changes done in #15951, so I am marking this WIP temporarily. |
miri64
added
State: WIP
|
Adapted tests for behavior changes of |
|
And added the new Kconfig stuff (which does not work properly yet, since dependency resolution of |
miri64
added
the
State: waiting for other PR
|
The test framework needed some rework (see #16111) to handle longer parameters, so I will base this PR now on that. |
miri64
force-pushed
the
congure/feat/congure_quic
branch
from
95e5479
to
c6e9a42
Compare
|
Rebased to current master and dependencies and added #16119 as new dependency. |
miri64
force-pushed
the
congure/feat/congure_quic
branch
from
ea01143
to
8b9d97f
Compare
maribu
added
CI: ready for build
|
I'm fine with this one going in only after feature freeze and clearing up the Murdock queue for now. |
miri64
added
CI: ready for build
benpicco
reviewed
Oct 16, 2022
miri64
force-pushed
the
congure/feat/congure_quic
branch
from
2b7aab2
to
1bf241e
Compare
benpicco
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This provides an implementation for CongURE of the congestion control mechanism of the QUIC protocol as specified in
draft-ietf-quic-recovery(version 34 at the opening of this PR). It has the advantage of having congestion control via loss and ECN already build in and also provides means for packet pacing, so perfect for SFR!Testing procedure
Tests are provided for which
riotctrl(at least v0.2.2) is required for them to run. If installed,should succeed.
Issues/PRs references
Requires
#15951(merged),#16111, and #16119.(merged) When merged, I will adapt the test framework to use the turo framework introduced in #15950, which was the original idea to begin with (which is why it is already printing JSON strings).