Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_sixlowpan_frag_sfr_congure: add congure_reno support #16170

Merged
merged 2 commits into from
Mar 1, 2023
Merged

gnrc_sixlowpan_frag_sfr_congure: add congure_reno support #16170

merged 2 commits into from
Mar 1, 2023

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Mar 9, 2021 •
edited
Loading

Contribution description

This provisions GNRC's 6LoWPAN SFR implementation with the CongURE implementation of TCP Reno. It also adds that implementation to the tests/gnrc_sixlowpan_frag_sfr_congure_impl test application.

Testing procedure

The test tests/gnrc_sixlowpan_frag_sfr_congure_impl where extended to support congure_reno:

CONGURE_IMPL=congure_reno make -C tests/gnrc_sixlowpan_frag_sfr_congure_impl

Ping some nodes with at least 1 hop separation with large payloads. Exchange between should work.

Issues/PRs references

Depends on #15953 (merged) and #16158 (merged) and their respective dependencies.

PR dependency graph

@miri64 miri64 added Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT State: waiting for other PR State: The PR requires another PR to be merged first labels Mar 9, 2021
@miri64 miri64 changed the title Gnrc sixlowpan frag sfr congure reno/feat/initial gnrc_sixlowpan_frag_sfr_congure: add congure_reno support Mar 9, 2021
@miri64 miri64 mentioned this pull request Mar 9, 2021
Merged
@miri64 miri64 force-pushed the gnrc_sixlowpan_frag_sfr_congure_reno/feat/initial branch from f51bfb1 to 8da19b4 Compare May 6, 2021 15:25
@miri64
Copy link
Member Author

miri64 commented May 6, 2021

Rebased and squashed to current master.

@MrKevinWeiss MrKevinWeiss added this to the Release 2021.07 milestone Jun 22, 2021
@MrKevinWeiss MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Mar 2, 2022
@miri64 miri64 removed the State: stale State: The issue / PR has no activity for >185 days label Mar 2, 2022
@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Sep 21, 2022
@miri64 miri64 removed the State: stale State: The issue / PR has no activity for >185 days label Sep 21, 2022
@miri64 miri64 mentioned this pull request Oct 12, 2022
Merged
@miri64 miri64 force-pushed the gnrc_sixlowpan_frag_sfr_congure_reno/feat/initial branch from 8da19b4 to 7f2adc0 Compare October 25, 2022 11:10
@github-actions github-actions bot added Area: build system Area: Build system Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration labels Oct 25, 2022
@github-actions github-actions bot added Area: sys Area: System Area: tests Area: tests and testing framework labels Oct 25, 2022
@miri64
Copy link
Member Author

miri64 commented Oct 25, 2022

Rebased and adopted for current master and dependencies, needs #18798 though, for the test application to link.

@benpicco
Copy link
Contributor

benpicco commented Mar 1, 2023

Needs a rebase

@miri64 miri64 force-pushed the gnrc_sixlowpan_frag_sfr_congure_reno/feat/initial branch from 7f2adc0 to 1d347dd Compare March 1, 2023 12:59
@miri64
Copy link
Member Author

miri64 commented Mar 1, 2023

Rebased to current master

@miri64 miri64 removed the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 1, 2023
@github-actions github-actions bot removed Area: Kconfig Area: Kconfig integration Area: doc Area: Documentation labels Mar 1, 2023
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 1, 2023
@miri64 miri64 mentioned this pull request Mar 1, 2023
Merged
@riot-ci
Copy link

riot-ci commented Mar 1, 2023 •
edited
Loading

Murdock results

✔️ PASSED

0d4ab77 tests: add congure_reno to SFR CongURE test

Success Failures Total Runtime
6902 0 6902 09m:35s

Artifacts

@benpicco
Copy link
Contributor

benpicco commented Mar 1, 2023

bors merge

@miri64
Copy link
Member Author

miri64 commented Mar 1, 2023

bors cancel. See #16159 (comment). There will be a merge conflict once #16159 is merged.

@bors
Copy link
Contributor

bors bot commented Mar 1, 2023

Canceled.

@miri64
Copy link
Member Author

miri64 commented Mar 1, 2023

(and since that merge conflict might propagate to #16171, I prefer #16159 to be merged first.

@miri64 miri64 force-pushed the gnrc_sixlowpan_frag_sfr_congure_reno/feat/initial branch from 1d347dd to 0d4ab77 Compare March 1, 2023 15:49
@miri64
Copy link
Member Author

miri64 commented Mar 1, 2023

Rebased to current master to resolve merge conflicts caused by merging #16159.

@miri64
Copy link
Member Author

miri64 commented Mar 1, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 1, 2023

Build succeeded:

@bors bors bot merged commit 2539521 into RIOT-OS:master Mar 1, 2023
@miri64 miri64 deleted the gnrc_sixlowpan_frag_sfr_congure_reno/feat/initial branch March 1, 2023 19:29
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@jia200x jia200x Awaiting requested review from jia200x

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@smlng smlng Awaiting requested review from smlng

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
4 participants
@miri64 @benpicco @riot-ci @MrKevinWeiss