Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/sam0_common: ethernet: fix RX detection #16383

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

benpicco
Copy link
Contributor

Contribution description

Detect RX of frame also when other bits of RSR are set.

Testing procedure

see #16298 (comment)

Issues/PRs references

fixes #16298

Detect RX of frame also when other bits of RSR are set.

fixes RIOT-OS#16298
@benpicco benpicco added Area: drivers Area: Device drivers Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 23, 2021
Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@benpicco
Copy link
Contributor Author

benpicco commented Apr 23, 2021

Something is still very odd here:

2021-04-23 18:44:27,843 #  ping 2600:: -i 100000
2021-04-23 18:44:34,454 # 12 bytes from 2600::: icmp_seq=0 ttl=49 time=6605.967 ms
2021-04-23 18:46:15,315 # 12 bytes from 2600::: icmp_seq=1 ttl=49 time=7464.275 ms
2021-04-23 18:47:54,313 # 12 bytes from 2600::: icmp_seq=2 ttl=49 time=6459.737 ms
2021-04-23 18:47:54,314 # 
2021-04-23 18:47:54,316 # --- 2600:: PING statistics ---
2021-04-23 18:47:54,321 # 3 packets transmitted, 3 packets received, 0% packet loss
2021-04-23 18:47:54,326 # round-trip min/avg/max = 6459.737/6843.326/7464.275 ms

(this is on the border router)

On my Linux machine I get

% ping 2600:: -c 3
PING 2600::(2600::) 56 data bytes
64 bytes from 2600::: icmp_seq=1 ttl=49 time=130 ms
64 bytes from 2600::: icmp_seq=2 ttl=49 time=130 ms
64 bytes from 2600::: icmp_seq=3 ttl=49 time=129 ms

--- 2600:: ping statistics ---
3 packets transmitted, 3 received, 0% packet loss, time 2003ms
rtt min/avg/max/mdev = 129.416/129.613/129.823/0.166 ms

@dylad
Copy link
Member

dylad commented Apr 23, 2021

@benpicco This might be another problem.
This fix is pretty simple and obvious so I think we should go with it first.
What do you think ?

@benpicco benpicco merged commit fed2c8e into RIOT-OS:master Apr 23, 2021
@benpicco benpicco deleted the sam0_eth/eth-netdev_fix_rec branch April 23, 2021 20:50
@MrKevinWeiss MrKevinWeiss added this to the Release 2021.07 milestone Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cpu/sam0_common: Ethernet driver stops working after a while
3 participants