gnrc_dhcpv6_client / uhcp: delay router advertisements until prefix was received #16755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
requested review from
cgundogan,
haukepetersen,
miri64 and
PeterKietzmann
as code owners
benpicco
force-pushed
the
gnrc_ipv6_nib-no_adv_router
branch
from
e1417e1
to
c0a019e
Compare
benpicco
added
the
Type: enhancement
benpicco
added
the
CI: ready for build
JKRhb
reviewed
Jan 4, 2022
JKRhb
reviewed
Jan 4, 2022
JKRhb
approved these changes
Jan 4, 2022
benpicco
force-pushed
the
gnrc_ipv6_nib-no_adv_router
branch
from
3e2332c
to
0504771
Compare
|
Thank you for the review! |
Huh? Didn't we fix this a while ago, that router solicitations go out the upstream interface? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The border router does not send out router solicitations as it sends out router advertisements instead.
This delays the reception of router advertisements from upstream routers.
Instead, start with router advertisements disabled and only enable them when we received a global prefix via DHCPv6 or UHCP.
Testing procedure
Run
examples/gnrc_border_routerboth withUSE_DHCPV6=1and without.You should notice that now a configuration on the upstream interface is obtained much faster.
Issues/PRs references
alternative to #16590