Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_ipv6_nib: queue packets that trigger probing on border router #16947

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 4, 2021

Contribution description

When probing for an unknown neighbor, the NIB on a 6LoWPAN border router currently drops the packet that triggered that probing in accordance with RFC 6775. However, it also does that on the upstream interface, as queuing support is removed at compile-time altogether. This adds an exception to the compile-time config

Testing procedure

Try to ping an Internet host via a border router from a 6LoWPAN host (see e.g. Task 8.5 of the release specs). The first message should go through with this PR, without it, the message will get lost.

Issues/PRs references

None, but the issue in #11988 might be related.

@miri64 miri64 added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label Oct 4, 2021
@github-actions github-actions bot added Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: sys Area: System labels Oct 4, 2021
@miri64 miri64 changed the title gnrc_ipv6_nib: queue probing packets on border router gnrc_ipv6_nib: packets that trigger probing on border router Oct 4, 2021
@miri64 miri64 force-pushed the gnrc_ipv6_nib/fix/queue-pkts-on-6lbr branch from ef32415 to b869184 Compare October 4, 2021 15:25
@miri64 miri64 added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Oct 4, 2021
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 4, 2021
@miri64 miri64 changed the title gnrc_ipv6_nib: packets that trigger probing on border router gnrc_ipv6_nib: queue packets that trigger probing on border router Oct 4, 2021
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Border router still works, this should also help with the issue described in #11551

@miri64
Copy link
Member Author

miri64 commented Oct 5, 2021

Only if in the setup (not fully) described in #11551 there are two interfaces and one of them uses 6LoWPAN.

@miri64
Copy link
Member Author

miri64 commented Oct 5, 2021

Backport provided in #16949

@miri64 miri64 deleted the gnrc_ipv6_nib/fix/queue-pkts-on-6lbr branch October 5, 2021 12:20
@fjmolinas fjmolinas added this to the Release 2022.01 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants