ieee802154/submac: avoid race condition between RX_DONE and ACK_TIMEOUT #16964
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR makes adapts the documentation of
ieee802154_submac_ack_timer_fired
to prevent execution whenieee802154_submac_ack_timer_cancel
was called. Since the SubMAC does not impose any rules on how it should be processed, this leaves the responsibility to the upper layer.This also adapts
netdev_submac_ieee802154
andtests/ieee802154_submac
accordingly.Testing procedure
It's very hard to trigger, but the consequences of this bug are more visible when using
socket_zep
(see #16932 (comment))Anyway, here's the test output for
tests/ieee802154_submac
andexamples/gnrc_lorawan
.Issues/PRs references
Discovered by @benpicco in #16932 (comment)