Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/wakaama: use ztimer #17103

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

This changes the platform adaption for Wakaama to use ztimer (ZTIMER_SEC) instead of xtimer.

Testing procedure

  • The example application should work as usual. Nodes should update their registration before it expires.

Issues/PRs references

Ticks an item of #13667

@github-actions github-actions bot added the Area: pkg Area: External package ports label Nov 2, 2021
@leandrolanzieri leandrolanzieri added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: pkg Area: External package ports and removed Area: pkg Area: External package ports labels Nov 2, 2021
@fjmolinas
Copy link
Contributor

The example application should work as usual. Nodes should update their registration before it expires.

What is the expiry time?

@leandrolanzieri
Copy link
Contributor Author

The example application should work as usual. Nodes should update their registration before it expires.

What is the expiry time?

The registration lifetime, which currently defaults to 300 seconds (https://doc.riot-os.org/group__lwm2m__client__config.html#gad11a3c875f5a688dad541aca7e137b27)

@fjmolinas
Copy link
Contributor

The example application should work as usual. Nodes should update their registration before it expires.

What is the expiry time?

The registration lifetime, which currently defaults to 300 seconds (https://doc.riot-os.org/group__lwm2m__client__config.html#gad11a3c875f5a688dad541aca7e137b27)

I can see it updated before expiry but not exactly at 5min, is that a problem?

image

@fjmolinas
Copy link
Contributor

The example application should work as usual. Nodes should update their registration before it expires.

What is the expiry time?

The registration lifetime, which currently defaults to 300 seconds (https://doc.riot-os.org/group__lwm2m__client__config.html#gad11a3c875f5a688dad541aca7e137b27)

I can see it updated before expiry but not exactly at 5min, is that a problem?

image

Same behaviour in master, so a non-issue.

image

Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@fjmolinas
Copy link
Contributor

Please rebase once #17104 is in

@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 2, 2021
@fjmolinas fjmolinas merged commit 555c8b2 into RIOT-OS:master Nov 2, 2021
@fjmolinas fjmolinas added this to the Release 2022.01 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants