Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/esp{32,8266}: model kconfig #17232

Merged
merged 22 commits into from
Dec 11, 2021

Conversation

leandrolanzieri
Copy link
Contributor

@leandrolanzieri leandrolanzieri commented Nov 18, 2021

Contribution description

This models the Kconfig modules for all boards based on ESP32 and ESP8266, I added one board of each CPU to the tests. For now the networking is not included. 6c7ce3d limits the CI to test only this two boards for now so we can iterate quickly, I'll remove it once everything is green.

Testing procedure

  • Green CI
  • Check the modelling and compare make info-modules list with and without TEST_KCONFIG=1, they should match.

Issues/PRs references

Depends on #17286
Depends on #17287
Depends on #17288
Depends on #17289

Part of #16875

@github-actions github-actions bot added Area: boards Area: Board ports Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: LoRa Area: LoRa radio support Area: pkg Area: External package ports Area: sys Area: System Platform: ESP Platform: This PR/issue effects ESP-based platforms Platform: native Platform: This PR/issue effects the native platform labels Nov 18, 2021
@leandrolanzieri leandrolanzieri added this to the Release 2022.01 milestone Nov 18, 2021
@gschorcht
Copy link
Contributor

@leandrolanzieri The changes of following files seem not to be related to ESPs:
cpu/native/Kconfig
cpu/native/vfs/Kconfig
drivers/ili9341/Kconfig
makefiles/features_modules.inc.mk
sys/Kconfig
sys/vfs/Kconfig
Are they included by mistake?

For the following file I'm not sure whether it has to do with the esp32-heltec-lora32-v2 board.
drivers/sx126x/Kconfig

@leandrolanzieri
Copy link
Contributor Author

@leandrolanzieri The changes of following files seem not to be related to ESPs: cpu/native/Kconfig cpu/native/vfs/Kconfig drivers/ili9341/Kconfig makefiles/features_modules.inc.mk sys/Kconfig sys/vfs/Kconfig Are they included by mistake?

For the following file I'm not sure whether it has to do with the esp32-heltec-lora32-v2 board. drivers/sx126x/Kconfig

They were not included by mistake but needed changes to model these boards. I can try to split them if you think it makes it easier.

@gschorcht
Copy link
Contributor

@leandrolanzieri The changes of following files seem not to be related to ESPs: cpu/native/Kconfig cpu/native/vfs/Kconfig drivers/ili9341/Kconfig makefiles/features_modules.inc.mk sys/Kconfig sys/vfs/Kconfig Are they included by mistake?

They were not included by mistake but needed changes to model these boards. I can try to split them if you think it makes it easier.

If they are needed not only by these boards, but also by others and were simply forgotten, we should provide them with a separate PR first.

@leandrolanzieri
Copy link
Contributor Author

@leandrolanzieri The changes of following files seem not to be related to ESPs: cpu/native/Kconfig cpu/native/vfs/Kconfig drivers/ili9341/Kconfig makefiles/features_modules.inc.mk sys/Kconfig sys/vfs/Kconfig Are they included by mistake?

They were not included by mistake but needed changes to model these boards. I can try to split them if you think it makes it easier.

If they are needed not only by these boards, but also by others and were simply forgotten, we should provide them with a separate PR first.

@gschorcht the other files were not 'simply forgotten'. We are currently in the middle of this migration, so many times we move forward by modelling whole boards/cpus which need peripheral work, that's why those changes were included here. It makes it easier to test and stresses less our CI. Nevertheless, I split this PR in #17286, #17287, #17288, #17289, which are dependencies for this one now.

@leandrolanzieri
Copy link
Contributor Author

Checked all log module combinations. It works like a charm.

Thanks a lot! I removed the CI limiting commit, let's give it a full run.

@gschorcht
Copy link
Contributor

Thanks a lot!

I have to thank for your great work and modelling "my" CPUs and boards and for your patience 😎

@gschorcht gschorcht merged commit 85313cc into RIOT-OS:master Dec 11, 2021
@leandrolanzieri leandrolanzieri deleted the pr/cpu/esp/model_kconfig branch December 12, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants