-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/esp{32,8266}: model kconfig #17232
cpu/esp{32,8266}: model kconfig #17232
Conversation
@leandrolanzieri The changes of following files seem not to be related to ESPs: For the following file I'm not sure whether it has to do with the |
They were not included by mistake but needed changes to model these boards. I can try to split them if you think it makes it easier. |
If they are needed not only by these boards, but also by others and were simply forgotten, we should provide them with a separate PR first. |
@gschorcht the other files were not 'simply forgotten'. We are currently in the middle of this migration, so many times we move forward by modelling whole boards/cpus which need peripheral work, that's why those changes were included here. It makes it easier to test and stresses less our CI. Nevertheless, I split this PR in #17286, #17287, #17288, #17289, which are dependencies for this one now. |
This avoids the generation of the unneeded modules periph_init_rtt_hw_rtc and periph_init_rtt_hw_sys.
f77c51e
to
a8201c0
Compare
Thanks a lot! I removed the CI limiting commit, let's give it a full run. |
This feature is provided by all esp32_wrover% models, so group it in the common file.
In order to work properly dependencies should be placed on the Makefile.dep files, not on Makefile.include.
I have to thank for your great work and modelling "my" CPUs and boards and for your patience 😎 |
Contribution description
This models the Kconfig modules for all boards based on ESP32 and ESP8266, I added one board of each CPU to the tests. For now the networking is not included. 6c7ce3d limits the CI to test only this two boards for now so we can iterate quickly, I'll remove it once everything is green.
Testing procedure
make info-modules
list with and withoutTEST_KCONFIG=1
, they should match.Issues/PRs references
Depends on #17286Depends on #17287Depends on #17288Depends on #17289Part of #16875