cpu/esp: revert the change for default definition of ESP_WIFI_PASS #17420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a default value for ESP_WIFI_PASS was intentionally defined only if DOXYGEN was also defined, to allow ESP_WIFI_PASS to be left undefined for using APs without authentication. With PR RIOT-OS#17415 the definition was changed to always define a default value for EPS_WIFI_PASS. This made it impossible to use APs without authentication. The commit reverts this change.
github-actions
bot
added
Area: cpu
gschorcht
added
CI: ready for build
This was referenced Dec 19, 2021
jeandudey
approved these changes
Dec 20, 2021
|
Thanks for reviewing and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR reverts a change made as part of PR #17415.
Previously, the default value for
ESP_WIFI_PASSwas intentionally defined only whenDOXYGENis also defined to allowESP_WIFI_PASSto be left undefined for using APs without authentication. As part of PR #17415 the definition was changed to always define a default value forEPS_WIFI_PASS. This made it impossible to use APs without authentication. This PR reverts this change.The change in PR #17415 that is undone by this PR was supposedly a correction and was made in preparation for the migration to
Kconfig. There are no other changes in PR #17415 affected by this change.Testing procedure
It is a very small fix back to the former definition (comment https://github.com/RIOT-OS/RIOT/pull/17415/files#r771905996). There are no functional or other changes affected by this change. Therefore, green CI should be sufficient.
Issues/PRs references
Fixes a bug introduced with PR #174153