Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/mtd_flashpage: add mtd_flashpage_t type #17627

Merged
merged 3 commits into from
Mar 25, 2022
Merged

drivers/mtd_flashpage: add mtd_flashpage_t type #17627

merged 3 commits into from
Mar 25, 2022

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Feb 8, 2022

Contribution description

This introduces a mtd_flashpage_t to make mtd_flashpage behave more like other MTD implementations.

Testing procedure

The generated code of tests/sys_fido2_ctap does not change.

Issues/PRs references

@benpicco benpicco requested a review from chrysn February 8, 2022 16:16
@github-actions github-actions bot added Area: drivers Area: Device drivers Area: sys Area: System Area: tests Area: tests and testing framework labels Feb 8, 2022
@benpicco benpicco added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 8, 2022
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 26, 2022
fjmolinas
fjmolinas approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, code did not change, good to align the API

@fjmolinas fjmolinas merged commit a10b157 into RIOT-OS:master Mar 25, 2022
@benpicco benpicco deleted the mtd_flashpage_t branch March 25, 2022 16:11
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@chrysn chrysn Awaiting requested review from chrysn

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.04
Development

Successfully merging this pull request may close these issues.
3 participants
@benpicco @fjmolinas @OlegHahm