Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/senml: do no include saul_default #17641

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

fjmolinas
Copy link
Contributor

Contribution description

Seems like my last test of #16384 was too old since an error sneaked in, the saul tests expect there to be no saul device present... so do not include saul-default.

Testing procedure

EXTERNAL_BOARD_DIRS= RYOT_CI=1 BOARD=samr21-xpro make -C tests/senml_saul/ flash test -j
Building application "tests_senml_saul" for "samr21-xpro" with MCU "samd21".

"make" -C /home/francisco/workspace/RIOT/pkg/nanocbor/ 
"make" -C /home/francisco/workspace/RIOT/build/pkg/nanocbor/src -f /home/francisco/workspace/RIOT/Makefile.base MODULE=nanocbor
"make" -C /home/francisco/workspace/RIOT/boards/samr21-xpro
"make" -C /home/francisco/workspace/RIOT/core
"make" -C /home/francisco/workspace/RIOT/cpu/samd21
"make" -C /home/francisco/workspace/RIOT/drivers
"make" -C /home/francisco/workspace/RIOT/sys
"make" -C /home/francisco/workspace/RIOT/drivers/periph_common
"make" -C /home/francisco/workspace/RIOT/drivers/saul
"make" -C /home/francisco/workspace/RIOT/sys/auto_init
"make" -C /home/francisco/workspace/RIOT/sys/embunit
"make" -C /home/francisco/workspace/RIOT/sys/fmt
"make" -C /home/francisco/workspace/RIOT/sys/isrpipe
"make" -C /home/francisco/workspace/RIOT/sys/malloc_thread_safe
"make" -C /home/francisco/workspace/RIOT/cpu/cortexm_common
"make" -C /home/francisco/workspace/RIOT/cpu/sam0_common
"make" -C /home/francisco/workspace/RIOT/cpu/samd21/periph
"make" -C /home/francisco/workspace/RIOT/cpu/sam0_common/periph
"make" -C /home/francisco/workspace/RIOT/sys/newlib_syscalls_default
"make" -C /home/francisco/workspace/RIOT/cpu/samd21/vectors
"make" -C /home/francisco/workspace/RIOT/sys/phydat
"make" -C /home/francisco/workspace/RIOT/sys/pm_layered
"make" -C /home/francisco/workspace/RIOT/sys/saul_reg
"make" -C /home/francisco/workspace/RIOT/sys/senml
"make" -C /home/francisco/workspace/RIOT/sys/stdio_uart
"make" -C /home/francisco/workspace/RIOT/sys/test_utils/interactive_sync
"make" -C /home/francisco/workspace/RIOT/sys/tsrb
"make" -C /home/francisco/workspace/RIOT/cpu/cortexm_common/periph
   text	   data	    bss	    dec	    hex	filename
  14612	    140	   2772	  17524	   4474	/home/francisco/workspace/RIOT/tests/senml_saul/bin/samr21-xpro/tests_senml_saul.elf
rsync --chmod=ugo=rwX /home/francisco/workspace/RIOT/tests/senml_saul/bin/samr21-xpro/tests_senml_saul.bin ci@ci-riot-tribe.saclay.inria.fr:/builds/boards/bin/samr21-xpro_flashfile.bin
ssh ci@ci-riot-tribe.saclay.inria.fr 'IMAGE_OFFSET= BOARD=samr21-xpro QUIET=1 make --no-print-directory -C /builds/boards flash-only FLASHFILE=/builds/boards/bin/samr21-xpro_flashfile.bin'
/builds/boards/RIOT/dist/tools/edbg/edbg.sh flash /builds/boards/bin/samr21-xpro_flashfile.bin
### Flashing Target ###
Debugger: ATMEL EDBG CMSIS-DAP ATML2127031800004957 01.1A.00FB (S)
Clock frequency: 16.0 MHz
Target: SAM R21G18 (Rev C)
Verification...
at address 0x4 expected 0xb1, read 0xb5
Error: verification failed
Debugger: ATMEL EDBG CMSIS-DAP ATML2127031800004957 01.1A.00FB (S)
Clock frequency: 16.0 MHz
Target: SAM R21G18 (Rev C)
Programming..... done.
Verification..... done.
Done flashing
r
ssh -t ci@ci-riot-tribe.saclay.inria.fr 'BOARD=samr21-xpro QUIET=1 make --no-print-directory -C /builds/boards cleanterm' 
/builds/boards/RIOT/dist/tools/pyterm/pyterm -p "/dev/riot/tty-samr21-xpro" -b "115200" --no-reconnect --noprefix --no-repeat-command-on-empty-line 
Twisted not available, please install it if you want to use pyterm's JSON capabilities
Connect to serial port /dev/riot/tty-samr21-xpro
Welcome to pyterm!
Type '/exit' to exit.
READY
s
START
main(): This is RIOT! (Version: 2022.04-devel-345-ga0ec1-pr_senml_saul_default)
.
OK (1 tests)

Issues/PRs references

Spotted in #16789

@fjmolinas fjmolinas added CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 11, 2022
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Feb 11, 2022
Copy link
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thanks for the cleanup

@bergzand bergzand merged commit f6b7255 into RIOT-OS:master Feb 11, 2022
@fjmolinas fjmolinas deleted the pr_senml_saul_default branch March 24, 2022 08:31
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants