Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/net/gnrc_sixlowpan_frag_sfr: use xtimer_set #17668

Merged
merged 1 commit into from
Feb 17, 2022
Merged

sys/net/gnrc_sixlowpan_frag_sfr: use xtimer_set #17668

merged 1 commit into from
Feb 17, 2022

Conversation

fjmolinas
Copy link
Contributor

Contribution description

The change should be trivial, use xtimer_is_set which does the same thing, and avoid touching .long_offset for ztimer compatibility. Since those are static variables they are initialized as 0 anyway.

Testing procedure

  • green murdock should do
make -C tests/gnrc_sixlowpan_frag flash test -j

LED_RED_OFF
LED_GREEN_ON
RIOT native board initialized.
RIOT native hardware initialization complete.

Help: Press s to start test, r to print it is ready
READY
s
START
main(): This is RIOT! (Version: 2022.04-devel-389-g13bb0-pr_sixlowpanfrag_xtimer_is_set)
..............
OK (14 tests)

Issues/PRs references

Split and adapted from #17365

@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 17, 2022
@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels Feb 17, 2022
kaspar030
kaspar030 approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030 kaspar030 merged commit b2a93b0 into RIOT-OS:master Feb 17, 2022
@fjmolinas fjmolinas deleted the pr_sixlowpanfrag_xtimer_is_set branch February 17, 2022 08:48
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

Assignees
No one assigned
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.04
Development

Successfully merging this pull request may close these issues.
3 participants
@fjmolinas @kaspar030 @OlegHahm