Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/net/dsm: add missing dependencies #17685

Merged
merged 1 commit into from
Feb 21, 2022
Merged

sys/net/dsm: add missing dependencies #17685

merged 1 commit into from
Feb 21, 2022

Conversation

fjmolinas
Copy link
Contributor

@fjmolinas fjmolinas commented Feb 21, 2022 •
edited by kaspar030
Loading

Contribution description

Caught by CI when running on #17670. sock_dtls is a module and not a feature, the Makefile.dep was never included, move it to the generic sys/Makefile.dep

Testing procedure

Green Murdock should be enough

Issues/PRs references

Split from #17670.

@fjmolinas fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 21, 2022
@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels Feb 21, 2022
kaspar030
kaspar030 approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@fjmolinas fjmolinas mentioned this pull request Feb 21, 2022
Merged
@benpicco benpicco merged commit ec6c590 into RIOT-OS:master Feb 21, 2022
@fjmolinas fjmolinas deleted the pr_dix_dsm_dep branch March 24, 2022 08:31
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

Assignees
No one assigned
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.04
Development

Successfully merging this pull request may close these issues.
4 participants
@fjmolinas @kaspar030 @benpicco @OlegHahm