sys/ztimer: cleanup xtimer_compat.h for 32Bit only #17690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: sys
kfessel
force-pushed
the
p-ztimer-xtimer-compat32
branch
from
7c06cc0
to
ae223ec
Compare
kfessel
force-pushed
the
p-ztimer-xtimer-compat32
branch
from
ae223ec
to
822dbc7
Compare
kfessel
added
the
CI: ready for build
|
LGTM, does it make sense to adapt the Kconfig message? Also could you uncrustify while you are touching the header? |
kfessel
commented
Feb 25, 2022
| uint64_t time = xtimer_usec_from_ticks64(ticks); | ||
|
|
||
| while (time > max_sleep) { | ||
| xtimer_usleep(clock, max_sleep); |
There was a problem hiding this comment.
there is a bug in this line
clock should be ZTIMER_USEC
There was a problem hiding this comment.
If you open a PR fixing this I noted that what could also be added:
- dummy XTIMER_BACKOFF
- xtimer_init
- xtimer_is_set
- xtimer_rmutex_lock_timeout
There was a problem hiding this comment.
right i will add them
kfessel
added a commit
to kfessel/RIOT
that referenced
this pull request
Feb 25, 2022
kfessel
added a commit
to kfessel/RIOT
that referenced
this pull request
Feb 25, 2022
kfessel
added a commit
that referenced
this pull request
Feb 25, 2022
sys/ztimer/xtimer_compat: fix bug introduced in #17690 and .. also adds missing dummy XTIMER_BACKOFF xtimer_init xtimer_is_set xtimer_rmutex_lock_timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
removes all functions from
ztimer/xtimer_compat.h(32 Bit) that are not implementable by using ztimer (32 Bit)if these functions are used
ztimer64/xtimer_compat.hshould be usedTesting procedure
Issues/PRs references
#17670