Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/libcose: add RIOT as crypto backend #17701

Merged
merged 3 commits into from
May 17, 2022
Merged

pkg/libcose: add RIOT as crypto backend #17701

merged 3 commits into from
May 17, 2022

Conversation

fjmolinas
Copy link
Contributor

@fjmolinas fjmolinas commented Feb 24, 2022 •
edited
Loading

Contribution description

This PR adds RIOT crypto as a potential crypto backend for libcose. Here only chacha20poly1305 is added, but this puts the base to extend.

As its only a crypto backend and not usable for signing I also split the encrypting part of the test into a generic test easy to extend with other crypto (stolen from libcose)

Testing procedure

  • green ci
  • review the random patch change to adapt to latest libcose master (many new stuff lately)

Related PRs

Waiting for bergzand/libcose#128
Waiting for #18003

@github-actions github-actions bot added Area: pkg Area: External package ports Area: tests Area: tests and testing framework labels Feb 24, 2022
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 15, 2022
@github-actions github-actions bot added the Area: sys Area: System label Apr 25, 2022
@fjmolinas fjmolinas added State: waiting for other PR State: The PR requires another PR to be merged first and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 25, 2022
@fjmolinas fjmolinas force-pushed the pr_libcose_riot_crypto branch 2 times, most recently from de54e45 to a7d8f17 Compare April 29, 2022 14:48
@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Apr 29, 2022
@github-actions github-actions bot removed the Area: sys Area: System label Apr 29, 2022
@fjmolinas fjmolinas requested a review from bergzand April 29, 2022 14:49
@fjmolinas
Copy link
Contributor Author

No longer waiting

@github-actions github-actions bot added Area: build system Area: Build system Area: Kconfig Area: Kconfig integration labels May 16, 2022
@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 16, 2022
@fjmolinas
Copy link
Contributor Author

@benpicco last push should have fixed the ci (only blacklisting missing), ok to squash?

@fjmolinas
Copy link
Contributor Author

All green here @bergzand @benpicco

@benpicco benpicco merged commit d7533fb into RIOT-OS:master May 17, 2022
@fjmolinas fjmolinas deleted the pr_libcose_riot_crypto branch May 17, 2022 15:11
@fjmolinas
Copy link
Contributor Author

Thanks!

@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@bergzand bergzand Awaiting requested review from bergzand

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
3 participants
@fjmolinas @benpicco @chrysn