Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/encx24j600: define default parameters #17747

Merged
merged 1 commit into from
Mar 5, 2022
Merged

drivers/encx24j600: define default parameters #17747

merged 1 commit into from
Mar 5, 2022

Conversation

leandrolanzieri
Copy link
Contributor

Contribution description

This adds default params to the encx24j600 (the values are taken from the test application), and modifies the auto_init code to support multiple driver instances.

Testing procedure

  • Green CI
  • Optionally run the test application (I could not do this as I don't have the device)

Issues/PRs references

Split from #17739

@github-actions github-actions bot added Area: drivers Area: Device drivers Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework labels Mar 4, 2022
@leandrolanzieri leandrolanzieri added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Mar 4, 2022
@github-actions github-actions bot added the Area: tools Area: Supplementary tools label Mar 4, 2022
MrKevinWeiss
MrKevinWeiss approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the doc issues are sorted and murdock is happy I ACK!

@MrKevinWeiss
Copy link
Contributor

Please squash

@leandrolanzieri leandrolanzieri force-pushed the drivers/encx24j600/default_params branch from 5b6ab25 to de79edb Compare March 4, 2022 08:58
@leandrolanzieri leandrolanzieri added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 4, 2022
@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 4, 2022
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 4, 2022
@benpicco benpicco merged commit f31fdfd into RIOT-OS:master Mar 5, 2022
@leandrolanzieri leandrolanzieri mentioned this pull request Mar 8, 2022
Merged
@OlegHahm OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

@smlng smlng Awaiting requested review from smlng

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.04
Development

Successfully merging this pull request may close these issues.
5 participants
@leandrolanzieri @MrKevinWeiss @benpicco @OlegHahm @fjmolinas