pkg/lvgl: add extra widget dependency #17760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
approved these changes
Mar 7, 2022
benpicco
added
the
CI: ready for build
fjmolinas
changed the title
aabadie
requested changes
Mar 8, 2022
There was a problem hiding this comment.
@benpicco, any reason why you approved this PR without comment ?
I checked in LVGL code and there's indeed an implicit dependency between tabview and btnmatrix widgets but it's not specified explicitly in their code, neither in the tabview.c nor in their Kconfig.
That should be fixed upstream.
Since we are doing the same automatic dependency resolution with the lv_win extra widget, there's no reason to also do it for tabview.
I'm blocking because you forgot to update Kconfig.
aabadie
changed the title
|
It appeared to be a simple enough change - but yea, if the pkg provides Kconfig that needs to be updated as well |
|
I have some more down the pipe, I'll bundle them together before fixing Kconfig |
fjmolinas
force-pushed
the
pkg_lvgl_widget_dep
branch
from
1aa95d9
to
62c848c
Compare
fjmolinas
force-pushed
the
pkg_lvgl_widget_dep
branch
from
62c848c
to
1567a08
Compare
fjmolinas
requested review from
leandrolanzieri,
jia200x and
cgundogan
as code owners
|
@aabadie I added Kconfig |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Just a missing dependency, not sure it's woth the full build.
Testing procedure
Add the module, see missing files.