-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xtimer: rework dependecies to ease backend switch #17809
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjmolinas
added
State: WIP
State: The PR is still work-in-progress and its code is not in its final presentable form yet
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Mar 15, 2022
fjmolinas
requested review from
leandrolanzieri,
jia200x,
cgundogan,
smlng,
aabadie,
MichelRottleuthner,
kaspar030 and
bergzand
as code owners
March 15, 2022 17:20
github-actions
bot
added
Area: arduino API
Area: Arduino wrapper API
Area: boards
Area: Board ports
Area: build system
Area: Build system
Area: cpu
Area: CPU/MCU ports
Area: drivers
Area: Device drivers
Area: Kconfig
Area: Kconfig integration
Area: pkg
Area: External package ports
Area: sys
Area: System
Area: tests
Area: tests and testing framework
Area: timers
Area: timer subsystems
Platform: ARM
Platform: This PR/issue effects ARM-based platforms
Platform: native
Platform: This PR/issue effects the native platform
Area: CI
Area: Continuous Integration of RIOT components
labels
Mar 15, 2022
fjmolinas
added
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
and removed
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Mar 15, 2022
fjmolinas
force-pushed
the
pr_xtimer_dep_rework
branch
2 times, most recently
from
March 15, 2022 21:24
caf0754
to
c0289e4
Compare
This allows for xtimer_on_ztimer depending on ZTIMER_PERIPH_TIMER and not on ZTIMER_USEC, avoiding the use of selects and therfore dependency loops in XTIMER_BACKEND
fjmolinas
force-pushed
the
pr_xtimer_dep_rework
branch
from
March 15, 2022 21:50
8724369
to
974b8d8
Compare
github-actions
bot
removed
the
Area: CI
Area: Continuous Integration of RIOT components
label
Mar 15, 2022
fjmolinas
removed
the
State: WIP
State: The PR is still work-in-progress and its code is not in its final presentable form yet
label
Mar 16, 2022
fjmolinas
force-pushed
the
pr_xtimer_dep_rework
branch
from
March 16, 2022 08:13
974b8d8
to
3ee23ce
Compare
fjmolinas
removed
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Mar 16, 2022
Closing in favor off #17811 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: arduino API
Area: Arduino wrapper API
Area: boards
Area: Board ports
Area: build system
Area: Build system
Area: cpu
Area: CPU/MCU ports
Area: drivers
Area: Device drivers
Area: Kconfig
Area: Kconfig integration
Area: pkg
Area: External package ports
Area: sys
Area: System
Area: tests
Area: tests and testing framework
Area: timers
Area: timer subsystems
Platform: ARM
Platform: This PR/issue effects ARM-based platforms
Platform: native
Platform: This PR/issue effects the native platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR sparks from #17721 (comment), trying to make the default backend change as close to a oneliner as possible. Because of #17721 (comment) I actually had to rework dependencies quite a bit, so Murdock might not be happy again... let's see.
With this change the default could be change with the following.
diff
Although adapting tests Makefile.ci will also be needed (17b3c6e and 6728d7c)
This PR also changes the auto-selection of the compat modules from
ztimer
toztimer_periph_timer
, it, therefore, allows having legacytimer
andztimer_msec
running onrtt
.From local testing (To be confirmed by murdock), I think this change allows getting rid of the
ZTIMER_USEC
indirection as well asZTIMER64_USEC
indirectionMarking as WIP will I let Murdock check I didn't make a fundamentally wrong change.
Testing procedure
Issues/PRs references
#17721