sys/net/application_layer/sock_dns_mock: add module for mocking sock_dns #17871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HendrikVE
requested review from
smlng,
leandrolanzieri,
aabadie,
MichelRottleuthner,
fjmolinas,
miri64,
haukepetersen,
PeterKietzmann and
cgundogan
as code owners
github-actions
bot
added
Area: build system
benpicco
reviewed
Mar 26, 2022
HendrikVE
force-pushed
the
pr/sock_dns_mock
branch
from
5d63635
to
5cc3cd6
Compare
HendrikVE
changed the title
HendrikVE
force-pushed
the
pr/sock_dns_mock
branch
from
5cc3cd6
to
3357d1b
Compare
benpicco
reviewed
Mar 27, 2022
HendrikVE
force-pushed
the
pr/sock_dns_mock
branch
2 times, most recently
from
7eec67f
to
56a1510
Compare
benpicco
added
the
CI: ready for build
benpicco
reviewed
Mar 31, 2022
sys/include/net/dns_mock.h
Outdated
Comment on lines
40
to
47
| #define SOCK_DNS_MOCK_EXAMPLE_COM_IPV4_STRING "93.184.216.34" | ||
|
|
||
| /** | ||
| * @brief IPv6 string related to the hostname when using sock_dns_mock | ||
| * | ||
| * @see @ref SOCK_DNS_MOCK_EXAMPLE_COM_HOSTNAME | ||
| */ | ||
| #define SOCK_DNS_MOCK_EXAMPLE_COM_IPV6_STRING "2606:2800:220:1:248:1893:25c8:1946" |
There was a problem hiding this comment.
At one point I thought about parsing the ipv4_addr_t into a string and compare it on a string basis, but I decided that this is an unnecessary step and that comparing it by ipv4_addr_equal is sufficient already. I kept them because in my opinion a define does not hurt and may be used later, but we can also remove these and simply mention the IP address in the doc of sock_dns_mock_example_com_addr_ipv4 and sock_dns_mock_example_com_addr_ipv6.
There was a problem hiding this comment.
Let’s remove it - I can easily see this getting out of sync with the actual address in the future.
There was a problem hiding this comment.
Removed and adapted documentation
HendrikVE
force-pushed
the
pr/sock_dns_mock
branch
from
56a1510
to
a9fb338
Compare
benpicco
approved these changes
Apr 3, 2022
|
@benpicco Thank you very much for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Makes
tests/netutils/mock_dns.cavailable globally as new module. It is useful for #17680 and #16853Testing procedure
Run
tests/netutils/main.c