Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/atwinc15x0: join multicast groups #17880

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

benpicco
Copy link
Contributor

Contribution description

I noticed the wifi module would not receive any router advertisements while an esp8266 did just fine.

Turns out joining the multicast groups was not enabled.
With this it works as expected.

Testing procedure

Just connect to a IPv6 enabled WiFi network:

nib: Handle timer event (ctx = 0x20001778, type = 0x4fc3, now = 4335ms)
nib: Handle packet (icmpv6->type = 134)
nib: Received valid router advertisement:
     - Source address: fe80::3e37:12ff:fe9a:7d18
     - Destination address: ff02::1
     - Cur Hop Limit: 255
     - Flags: -O
     - Router Lifetime: 1800s
     - Reachable Time: 0ms
     - Retrans Timer: 0ms
nib: received valid Prefix Information option:
     - Prefix: 2a00:20:6006:a846::/64
     - Flags: LA
     - Valid lifetime: 7200
     - Preferred lifetime: 3600
nib: Handle timer event (ctx = 0x200017ba, type = 0x4fd1, now = 4414ms)
nib: Handle timer event (ctx = 0x200017ba, type = 0x4fd2, now = 5422ms)
ifconfig
Iface  5  HWaddr: F8:F0:05:A9:EC:19  Channel: 6  RSSI: -37  Link: up
           State: IDLE
          L2-PDU:1500  MTU:1500  HL:255  Source address length: 6
          Link type: wireless
          inet6 addr: fe80::faf0:5ff:fea9:ec19  scope: link  VAL
          inet6 addr: 2a00:20:6006:a846:faf0:5ff:fea9:ec19  scope: global  VAL
          inet6 group: ff02::1
          inet6 group: ff02::1:ffa9:ec19

          Statistics for Layer 2
            RX packets 7  bytes 526
            TX packets 4 (Multicast: 4)  bytes 148
            TX succeeded 2 errors 0
          Statistics for IPv6
            RX packets 1  bytes 152
            TX packets 4 (Multicast: 4)  bytes 232
            TX succeeded 4 errors 0

Without this patch I would never receive a global address/router advertisement.

Issues/PRs references

I noticed the wifi module would not receive any router advertisements
while an esp8266 did just fine.

Turns out joining the multicast groups was not enabled.
With this it works as expected.
@github-actions github-actions bot added the Area: drivers Area: Device drivers label Mar 29, 2022
@benpicco benpicco added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 29, 2022
@benpicco benpicco requested a review from aabadie March 29, 2022 16:49
@benpicco benpicco added this to the Release 2022.04 milestone Mar 31, 2022
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, test output is provided.

@fjmolinas fjmolinas enabled auto-merge April 7, 2022 13:42
@fjmolinas fjmolinas merged commit 8b18898 into RIOT-OS:master Apr 7, 2022
@benpicco benpicco deleted the drivers/atwinc15x0-mcast branch April 7, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants