unittests: enable ASAN on native #18099
Conversation
Previous value tripped ASAN. Increase to sth with room to spare.
github-actions
bot
added
Area: boards
kaspar030
added
the
CI: ready for build
| @@ -48,8 +48,7 @@ | |||
| } \ | |||
| } while (0) | |||
|
|
|||
| #define VEC_MSG_LEN (sizeof("Unexpected userinfo member \"\" for \"\"") + \ | |||
| 64U + 8U) | |||
| #define VEC_MSG_LEN (256) | |||
There was a problem hiding this comment.
This was like ~110 before. tests are executed pretty low on the stack, so this should be ok.
There was a problem hiding this comment.
Can you tell which test exactly tripped the asan? The original VEC_MSG_LEN might be based on a wrong assumption, which in testing is always a warning sign.
There was a problem hiding this comment.
(so I'd rather fix the value for the correct assumption than just making it large enough, to account for exactly those kind of wrong assumptions)
There was a problem hiding this comment.
Ah... Just saw, that this is just for the output messages of the assert... so nvm.
There was a problem hiding this comment.
jup, my debugging went the same way, but it was actually the first test (so first message) where it tripped. Then I tried to parse the macro for why this fails, but that was not very fruitful.
|
(unrelated build failure in |
kaspar030
added
CI: ready for build
Contribution description
This PR wires up the Address Sanitizer for the unittests on native.
Another
PRcommit fixes the last remaining issue ASAN reported (a scratch buffer was too small in tests-uri_parser).Testing procedure
This only affects native, and makes it running unittests more likely to fail. CI tests all of it.
Issues/PRs references
#17800