Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/atwinc15x0: add timeout to init #18214

Merged
merged 1 commit into from
Jun 16, 2022
Merged

drivers/atwinc15x0: add timeout to init #18214

merged 1 commit into from
Jun 16, 2022

Conversation

benpicco
Copy link
Contributor

Contribution description

This enables a timeout on init to not hang there forever if init fails but instead return an error.

Testing procedure

Run tests/driver_atwinc15x0 on any board without the module connected.
On master this would hang indefinitely, with this patch you get

[atwinc15x0] Driver initialization error -5
2022-06-15 18:18:09,854 - INFO # gnrc_netif: init failed: -5
2022-06-15 18:18:09,859 - INFO # main(): This is RIOT! (Version: 2022.07-devel-770-g9827e)
2022-06-15 18:18:09,859 - INFO # >

Issues/PRs references

upstream PR arduino-libraries/WiFi101#335

@benpicco
drivers/atwinc15x0: add timeout to init
9c8fa57 
This enables a timeout on init to not hang there forever if init
fails but instead return an error.
@github-actions github-actions bot added the Area: pkg Area: External package ports label Jun 15, 2022
gschorcht
gschorcht approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@gschorcht gschorcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes absolutely sense. Works as expected.

@gschorcht gschorcht added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 16, 2022
@gschorcht gschorcht merged commit 058c882 into RIOT-OS:master Jun 16, 2022
@gschorcht
Copy link
Contributor

@benpicco Thanks for that contribution.

@benpicco benpicco deleted the drivers/atwinc15x0-timeout branch June 16, 2022 09:55
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschorcht gschorcht gschorcht approved these changes

Assignees
No one assigned
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
3 participants
@benpicco @gschorcht @chrysn