cpu/esp32: replace RIOT ESP32 SoC startup function by ESP-IDF SoC startup function #18268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: cpu
gschorcht
added
Type: enhancement
gschorcht
force-pushed
the
cpu/esp32/use_esp_idf_startup
branch
from
38ece14
to
30c4534
Compare
gschorcht
added
CI: ready for build
benpicco
reviewed
Jun 28, 2022
benpicco
reviewed
Jul 10, 2022
| /* set log levels for SDK library outputs */ | ||
| extern void esp_log_level_set(const char* tag, esp_log_level_t level); | ||
| esp_log_level_set("wifi", LOG_DEBUG); | ||
| esp_log_level_set("gpio", LOG_DEBUG); |
There was a problem hiding this comment.
Won't this increase verbosity by a lot? Or is this not what I think it is?
There was a problem hiding this comment.
It doesn't increase verbosity, it just sets the maximum level allowed for the gpio component.
gschorcht
force-pushed
the
cpu/esp32/use_esp_idf_startup
branch
from
e5919f5
to
81cafa5
Compare
gschorcht
force-pushed
the
cpu/esp32/use_esp_idf_startup
branch
from
81cafa5
to
6dd2659
Compare
I had to rebase to resolve conflicts. |
|
@benpicco Thanks for reviewing and merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is a split-off from PR #17841. It replaces the RIOT ESP32 SoC startup function
call_start_cpu0including clock settings by the startup function as provided with the ESP-IDF. The ESP-IDF SoC startup function can be used for all different ESP32x SoC variants.This PR depends on PR #18261.Testing procedure
Issues/PRs references
Split-off from PR #17841
Depends on PR #18261