Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/esp32: use to ESP-IDF twai HAL for periph/can #18278

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR is a split-off from PR #17841 and provides the changes to use the ESP-IDF twai HAL for periph/can.

Testing procedure

Compile and test with

BOARD=esp32-wroom-32 make -j8 -C tests/conn_can flash term

Issues/PRs references

Split-off from PR #17841

@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Jun 28, 2022
@gschorcht gschorcht requested a review from benpicco June 28, 2022 18:34
@gschorcht gschorcht added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Jun 28, 2022
@benpicco benpicco requested a review from wosym July 11, 2022 20:44
cpu/esp32/periph/can.c Outdated Show resolved Hide resolved
cpu/esp32/periph/can.c Outdated Show resolved Hide resolved
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash

@gschorcht gschorcht force-pushed the cpu/esp32/periph_hal_esp32_can branch from 046e3d8 to fccd382 Compare July 14, 2022 13:52
@gschorcht gschorcht added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 14, 2022
@benpicco benpicco merged commit de5472c into RIOT-OS:master Jul 15, 2022
@gschorcht
Copy link
Contributor Author

@benpicco Thanks for reviewing and merging.

@gschorcht gschorcht deleted the cpu/esp32/periph_hal_esp32_can branch July 15, 2022 09:08
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants