Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/lvgl7: remove deprecated package #18304

Merged
merged 1 commit into from
Jul 11, 2022
Merged

pkg/lvgl7: remove deprecated package #18304

merged 1 commit into from
Jul 11, 2022

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Jul 8, 2022

Contribution description

This package was marked for removal after 2022.04. So it's time to actually remove it.

Testing procedure

Green Murdock should be enough

Issues/PRs references

Marked as deprecated in #17681

@github-actions github-actions bot added Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports labels Jul 8, 2022
@aabadie aabadie added Process: removal Integration Process: The PR is removing a deprecated feature or API CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jul 8, 2022
@aabadie
Copy link
Contributor Author

aabadie commented Jul 8, 2022

I skipped the build since this package is not built anyway.

chrysn
chrysn approved these changes Jul 10, 2022
View reviewed changes
Copy link
Member

@chrysn chrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's have that in the release as announced.

@aabadie aabadie merged commit 2e0746d into RIOT-OS:master Jul 11, 2022
@aabadie aabadie deleted the pr/pkg/lvgl7_remove branch July 11, 2022 04:25
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrysn chrysn chrysn approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

Assignees
No one assigned
Labels
Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: removal Integration Process: The PR is removing a deprecated feature or API
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
2 participants
@aabadie @chrysn