Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcoap_dns: Add DNS cache support #18329

Merged
merged 2 commits into from
Jul 21, 2022
Merged

gcoap_dns: Add DNS cache support #18329

merged 2 commits into from
Jul 21, 2022

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jul 19, 2022

Contribution description

This adds DNS cache support to our DNS over CoAP implementation gcoap_dns.

Testing procedure

Both of the following commands should succeed:

make -C tests/gcoap_dns/ flash -j test                      # also tested by Murdock
USEMODULE=dns_cache make -C tests/gcoap_dns/ flash -j test  # NOT tested by Murdock

Issues/PRs references

Follow-up on #16705 and #18318.

@miri64 miri64 added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Jul 19, 2022
@github-actions github-actions bot added Area: CoAP Area: Constrained Application Protocol implementations Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework labels Jul 19, 2022
@miri64 miri64 requested review from benpicco and chrysn July 19, 2022 14:42
@miri64 miri64 force-pushed the gcoap_dns/enh/dns-caching branch from 9d21419 to 5160f30 Compare July 19, 2022 14:45
This was referenced Jul 19, 2022
Merged
Merged
@miri64 miri64 force-pushed the gcoap_dns/enh/dns-caching branch from 5160f30 to 5bba58b Compare July 20, 2022 08:48
@miri64
Copy link
Member Author

miri64 commented Jul 20, 2022

Rebased to current master and adapted for #18330.

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 20, 2022
@benpicco benpicco merged commit 1787442 into RIOT-OS:master Jul 21, 2022
@miri64
Copy link
Member Author

miri64 commented Jul 21, 2022

Thanks for the review!

@miri64 miri64 deleted the gcoap_dns/enh/dns-caching branch July 21, 2022 15:54
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@chrysn chrysn Awaiting requested review from chrysn

Assignees
No one assigned
Labels
Area: CoAP Area: Constrained Application Protocol implementations Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.10
Development

Successfully merging this pull request may close these issues.
4 participants
@miri64 @chrysn @benpicco @maribu