Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vfs: introduce vfs_format_by_path() #18447

Merged
merged 3 commits into from
Aug 17, 2022
Merged

vfs: introduce vfs_format_by_path() #18447

merged 3 commits into from
Aug 17, 2022

Conversation

benpicco
Copy link
Contributor

Contribution description

This adds vfs_format_by_path() analoguous to vfs_mount_by_path() and vfs_unmount_by_path().

Just as with vfs_format() the file system needs to be unmounted first before it can be formatted.

Testing procedure

> vfs w /nvm0/test.txt ascii a "Hello World!"
> ls /nvm0
./
../
test.txt	12 B
total 1 files

> vfs format /nvm0
-EBUSY

> vfs umount /nvm0
> vfs format /nvm0
> vfs mount /nvm0
> ls /nvm0
./
../
total 0 files

Issues/PRs references

@github-actions github-actions bot added the Area: sys Area: System label Aug 12, 2022
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 15, 2022
maribu
maribu approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Code looks good, trusting your testing

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 16, 2022
@benpicco
Copy link
Contributor Author

The failure of compile/tests/xtimer_now64_continuity/esp32-heltec-lora32-v2:gnu is unrelated.

@benpicco benpicco added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 16, 2022
@benpicco benpicco merged commit dffac04 into RIOT-OS:master Aug 17, 2022
@benpicco benpicco deleted the vfs_formaat_by_path branch August 17, 2022 10:04
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

Assignees
No one assigned
Labels
Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs
Projects
None yet
Milestone
Release 2022.10
Development

Successfully merging this pull request may close these issues.
2 participants
@benpicco @maribu