-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nanocoap_sock: add nanocoap_sock_put() #18514
Conversation
d7c4268
to
f8dd952
Compare
f8dd952
to
990b097
Compare
990b097
to
13f9012
Compare
13f9012
to
88adf71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid and works, analog to nanocoap_sock_get()
:
2022-08-30 11:31:13,662 # server start
2022-08-30 11:31:13,665 # starting server on port 5683
2022-08-30 11:55:35,297 # url put coap://[fe80::4c49:6f54:4f76:0%6]/value 22
2022-08-30 11:59:46,987 # url get coap://[fe80::4c49:6f54:4f76:0%6]/value
2022-08-30 11:59:47,015 # offset 000: 22
The next steps would be nanocoap_{put | post}_blockwise_url
?
We've got |
But blockwise PUT / POST is not intended for the simple |
It's a more convenient API for simple PUT/POST when no block-wise is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a more convenient API for simple PUT/POST when no block-wise is needed.
Ok, ACK
Thank you for the quick review! |
Contribution description
Same as
nanocoap_sock_get()
, but for PUT and POST.Testing procedure
Run two instances of
tests/nanocoap_cli
, on one do aserver start
and on the otherIssues/PRs references