Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/net: include misplacement inside linkage-specification #18587

Merged
merged 1 commit into from
Sep 15, 2022
Merged

sys/net: include misplacement inside linkage-specification #18587

merged 1 commit into from
Sep 15, 2022

Conversation

Ziesie1
Copy link
Contributor

@Ziesie1 Ziesie1 commented Sep 13, 2022

The include "sock_types.h" should be outside of the linkage-specification.

extern "C"
{
   // #include "sock_types.h"
}

#include "sock_types.h" // outside

The header "sock_types.h" has his own linkage-specification.
Otherwise this leads to problems in IntelliSense in VS Code.

@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels Sep 13, 2022
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 13, 2022
@benpicco
Copy link
Contributor

Please prefix the commit title with the subsystem - basically, just use the same title as you did for the PR.

@Ziesie1
sys/net: include misplacement inside linkage-specification
be10ffe 
An include should be outside of the linkage-specification.
@Ziesie1
Copy link
Contributor Author

Ziesie1 commented Sep 14, 2022

Ok sorry.
I hope now its fine.

@maribu
Copy link
Member

maribu commented Sep 14, 2022

Can you do a rebase of this PR branch on top of master? There now is a merge commit in this PR that shouldn't be here.

@Ziesie1
Copy link
Contributor Author

Ziesie1 commented Sep 14, 2022

Done!

@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 14, 2022
@maribu maribu merged commit 2dd1854 into RIOT-OS:master Sep 15, 2022
@maribu
Copy link
Member

maribu commented Sep 15, 2022

Thx for the fix!

@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

Assignees
No one assigned
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2022.10
Development

Successfully merging this pull request may close these issues.
3 participants
@Ziesie1 @benpicco @maribu