Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: update CI badge #18685

Merged
merged 1 commit into from
Nov 14, 2022
Merged

README.md: update CI badge #18685

merged 1 commit into from
Nov 14, 2022

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Oct 4, 2022

Contribution description

Before I forget, this PR is updating the README links to the CI status badge and job details of the new Murdock instance.

Testing procedure

Check the README:

  • the badge is displayed
  • the link points to the last nightly job run on master

Issues/PRs references

This is part of the migration to the new Murdock instance

@aabadie aabadie requested a review from jia200x as a code owner October 4, 2022 08:24
@github-actions github-actions bot added the Area: doc Area: Documentation label Oct 4, 2022
@aabadie aabadie added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 4, 2022
@riot-ci
Copy link

riot-ci commented Oct 4, 2022 •
edited
Loading

Murdock results

✔️ PASSED

f54f81d README.md: update CI badge

Success Failures Total Runtime
1 0 1 48s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

@miri64
Copy link
Member

miri64 commented Oct 8, 2022

Does it make sense to merge this?

  1. ci-prod is not a full build in the nightlies
  2. If I understand correctly, once ci-prod replaces ci, it will point to the ci.riot-os.org name again.

@aabadie
Copy link
Contributor Author

aabadie commented Oct 9, 2022

Does it make sense to merge this?

I think so :) but not before ci-prod.riot-os.org becomes ci.riot-os.org and after the urls in this PR are updated accordingly. The PR is essentially here to show that this feature won't be lost (and that I won't forget it).

@miri64 miri64 added the State: waiting for CI update State: The PR requires an Update to CI to be performed first label Oct 9, 2022
@miri64
Copy link
Member

miri64 commented Oct 9, 2022

Then let's set the appropriate label for now.

miri64
miri64 previously requested changes Oct 9, 2022
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preventing accidental merges before ci-prod became ci. Feel free to dismiss this review, once this is the case.

@github-actions github-actions bot removed the Area: CI Area: Continuous Integration of RIOT components label Nov 14, 2022
@miri64 miri64 dismissed their stale review November 14, 2022 13:37

Migration is happening now.

@aabadie
Copy link
Contributor Author

aabadie commented Nov 14, 2022

Once the DNS update is ready (ci.riot-os.org pointing to the new Murdock), this PR can be merged.

@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 14, 2022
@aabadie
Copy link
Contributor Author

aabadie commented Nov 14, 2022

Once the DNS update is ready (ci.riot-os.org pointing to the new Murdock), this PR can be merged.

The DNS is in place and both links work so this can now be merged.

@aabadie aabadie merged commit 52181c0 into RIOT-OS:master Nov 14, 2022
@aabadie aabadie deleted the pr/readme_ci_status branch November 14, 2022 15:39
@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrysn chrysn chrysn approved these changes

@miri64 miri64 miri64 left review comments

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees
No one assigned
Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs State: waiting for CI update State: The PR requires an Update to CI to be performed first
Projects
None yet
Milestone
Release 2023.01
Development

Successfully merging this pull request may close these issues.
5 participants
@aabadie @riot-ci @miri64 @chrysn @kaspar030