Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add deprecation notice on deprecated pseudo-modules #18698

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 6, 2022

Contribution description

Alternative to the non-semantical page introduced in #18649.

Testing procedure

make doc and look at the resulting doc/doxygen/html/deprecated.html (or see documentation artifcats in #18698 (comment)).

Issues/PRs references

Alternative to a proposal in #18649.

@github-actions github-actions bot added Area: build system Area: Build system Area: sys Area: System labels Oct 6, 2022
@miri64 miri64 added Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Oct 6, 2022
@riot-ci
Copy link

riot-ci commented Oct 6, 2022

Murdock results

✔️ PASSED

bb92b2b doc: add deprecation notice on deprecated pseudo-modules

Success Failures Total Runtime
1 0 1 01m:14s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

Comment on lines 81 to 87
## @addtogroup net_gcoap_dns
## @{
## Enable the @ref gcoap_dns function
PSEUDOMODULES += gcoap_dns
## Enable the @ref gcoap_dns_server_proxy_set function
PSEUDOMODULES += gcoap_dns_proxied
## @}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those lines were added, because otherwise Doxygen would include these to gnrc_netdev_default's documentation.

Comment on lines -45 to +46
* Finally, the module `event_thread_lowest` is provided for backward
* compatibility and has no effect.
* Finally, the module [event_thread_lowest](@ref sys_event_thread_lowest) is
* provided for backward compatibility and has no effect.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly added this here, so the missing reference will be caught, once event_thread_lowest is removed in earnest.

@github-actions github-actions bot removed the Area: doc Area: Documentation label Oct 6, 2022
Copy link
Member

@chrysn chrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough, and any prettiness shortcomings are better addressed on the level of the pseudomodules documentation.

@miri64 miri64 enabled auto-merge October 6, 2022 11:25
@miri64 miri64 merged commit a49863e into RIOT-OS:master Oct 6, 2022
@miri64 miri64 deleted the doc/enh/deprecated-modules branch October 7, 2022 09:47
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants