Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_schc: Initial import #18700

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

gnrc_schc: Initial import #18700

wants to merge 6 commits into from
+1,729 −14

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 6, 2022 •
edited
Loading

Contribution description

This is the second part of my porting of #15040. Since libSCHC is itself still very experimental, this PR and the feature is also still to be seen as experimental.

TODOs:

  • Find better way to optimize RAM usage of gnrc_networking example.
  • Put rules more in line with the example(s).
  • Testing procedures

Testing procedure

TBD, but sending SCHC frames via both TTN and the SCHC-via-Ethernet functionality provided by this PR were already tested.

Issues/PRs references

Taking-over for #15040, depends on #18515 (merged) and #18699 (merged).

@miri64 miri64 added Type: new feature The issue requests / The PR implemements a new feature for RIOT State: waiting for other PR State: The PR requires another PR to be merged first labels Oct 6, 2022
@github-actions github-actions bot added Area: build system Area: Build system Area: CI Area: Continuous Integration of RIOT components Area: doc Area: Documentation Area: examples Area: Example Applications Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: tests Area: tests and testing framework labels Oct 6, 2022
@miri64 miri64 mentioned this pull request Oct 6, 2022
Closed
This was referenced Oct 7, 2022
Merged
Merged
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Oct 7, 2022
@riot-ci
Copy link

riot-ci commented Oct 7, 2022 •
edited
Loading

Murdock results

❌ FAILED

4b7405f Revert "REMOVE ME! limit murdock builds to libSCHC test application"

Build failures (4)
Application Target Toolchain Runtime (s) Worker
tests/gnrc_ndp native gnu 0.51 beast
tests/gnrc_ndp nrf52840dk gnu 0.64 beast
tests/gnrc_ndp samr21-xpro gnu 0.62 beast
tests/gnrc_ndp esp32-wroom-32 gnu 4.14 beast

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

@miri64 miri64 mentioned this pull request Oct 7, 2022
Merged
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 7, 2022
@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 7, 2022
@github-actions github-actions bot removed the Area: CI Area: Continuous Integration of RIOT components label Oct 7, 2022
@miri64 miri64 removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 7, 2022
@miri64 miri64 force-pushed the gnrc_schc/feat/initial branch 3 times, most recently from 7ca81c0 to 5db7bfc Compare October 17, 2022 14:31
@miri64 miri64 force-pushed the gnrc_schc/feat/initial branch 5 times, most recently from 398d9f4 to bbde760 Compare October 28, 2022 11:45
@miri64 miri64 mentioned this pull request Nov 2, 2022
Closed
@github-actions github-actions bot added the Area: CI Area: Continuous Integration of RIOT components label Feb 21, 2023
@miri64 miri64 mentioned this pull request Feb 22, 2023
Merged
3 tasks
@miri64 miri64 removed the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 2, 2023
@github-actions github-actions bot removed Area: CI Area: Continuous Integration of RIOT components Area: tests Area: tests and testing framework labels Mar 2, 2023
@miri64
Copy link
Member Author

miri64 commented Mar 2, 2023

Rebased and squashed to current master, now that #18515 is merged.

@geonnave
Copy link
Contributor

Hi @miri64, I came across this PR and I just wanted to let you know that I am interested in using SCHC with RIOT.

@miri64
Copy link
Member Author

miri64 commented Aug 31, 2023

Hi @miri64, I came across this PR and I just wanted to let you know that I am interested in using SCHC with RIOT.

Great! I will continue work on this soon, though libSCHC already received some new updates which probably should be ported first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri will be requested when the pull request is marked ready for review leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x will be requested when the pull request is marked ready for review jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss will be requested when the pull request is marked ready for review MrKevinWeiss is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann will be requested when the pull request is marked ready for review PeterKietzmann is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: doc Area: Documentation Area: examples Area: Example Applications Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miri64 @riot-ci @geonnave @aabadie @bartmoons