Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket_zep: make use of crc16_ccitt_false_update() #18779

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

benpicco
Copy link
Contributor

Contribution description

Use crc16_ccitt instead of ucrc16 as it is faster and smaller than the generic CRC16 implementation.

Testing procedure

ZEP can still communicate with an unmodified instance.

Iface  7  HWaddr: 50:3C  Channel: 26  NID: 0x23  PHY: O-QPSK 
          Long HWaddr: E6:DF:AB:47:75:1A:50:3C 
           State: IDLE 
          ACK_REQ  L2-PDU:102  MTU:1280  HL:64  RTR  
          RTR_ADV  6LO  IPHC  
          Source address length: 8
          Link type: wireless
          inet6 addr: fe80::e4df:ab47:751a:503c  scope: link  VAL
          inet6 addr: 2001:db8::e4df:ab47:751a:503c  scope: global  VAL
          inet6 group: ff02::2
          inet6 group: ff02::1
          inet6 group: ff02::1:ff1a:503c
          inet6 group: ff02::1a
          
          Statistics for Layer 2
            RX packets 3  bytes 222
            TX packets 3 (Multicast: 2)  bytes 0
            TX succeeded 3 errors 0
          Statistics for IPv6
            RX packets 2  bytes 224
            TX packets 3 (Multicast: 2)  bytes 210
            TX succeeded 3 errors 0

> ping ff02::1
ping ff02::1
12 bytes from fe80::e8c8:a4b0:2429:4113%7: icmp_seq=0 ttl=64 rssi=0 dBm time=0.682 ms
12 bytes from fe80::e8c8:a4b0:2429:4113%7: icmp_seq=1 ttl=64 rssi=0 dBm time=0.657 ms
12 bytes from fe80::e8c8:a4b0:2429:4113%7: icmp_seq=2 ttl=64 rssi=0 dBm time=0.715 ms

--- ff02::1 PING statistics ---
3 packets transmitted, 3 packets received, 0% packet loss
round-trip min/avg/max = 0.657/0.684/0.715 ms

Issues/PRs references

@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: native Platform: This PR/issue effects the native platform labels Oct 20, 2022
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 20, 2022
@riot-ci
Copy link

riot-ci commented Oct 20, 2022

Murdock results

✔️ PASSED

2bb657c socket_zep: make use of crc16_ccitt

Success Failures Total Runtime
1991 0 1991 06m:29s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

@benpicco benpicco merged commit f021130 into RIOT-OS:master Oct 21, 2022
@benpicco benpicco deleted the socket_zep-crc16_ccitt branch October 21, 2022 09:02
@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: native Platform: This PR/issue effects the native platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants