boards/common/nrf52: improve default clock config #18811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- All nRF52 timers support 32 bit mode, so use that - All nRF52 timers support at least 4 channels, the timers NRF_TIMER3 and NRF_TIMER4 even support 6 channels. - Add a warning that `TIMER_DEV(1)` is used by the IEEE 802.15.4 driver
benpicco
added
the
CI: ready for build
Murdock results✔️ PASSED 4d02e15 boards/common/nrf52: improve default clock config
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
bergzand
approved these changes
Nov 21, 2022
|
Thx :) |
|
F**k. With this merged Likely because I changed the timer used by the nRF52 IEEE 802.15.4 driver from 8 bit to 32 bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
TIMER_DEV(1)is used by the IEEE 802.15.4 driverTesting procedure
Use a timer other than
TIMER_DEV(0)(that is used by ztimer) and set a timeout that cannot be represented in 8 bits. This should now work.Issues/PRs references
Needed for #18392 to work