Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/bitfield: add bf_find_first_{set, unset}() #18833

Merged
merged 4 commits into from
Nov 7, 2022

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Nov 2, 2022

Contribution description

I noticed that I needed these functions independent from #17045 and just as I was about to re-implement them, stale bot reminded me that I already did so a year ago.

So let's try to salvage them from that PR.

Testing procedure

Unittests are provided an can be build with

make -C tests/unittests tests-bitfield

Issues/PRs references

split from #17045

@benpicco benpicco requested a review from miri64 as a code owner November 2, 2022 12:01
@github-actions github-actions bot added Area: sys Area: System Area: tests Area: tests and testing framework labels Nov 2, 2022
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 2, 2022
@riot-ci
Copy link

riot-ci commented Nov 2, 2022

Murdock results

✔️ PASSED

1737430 tests/unittests: add tests for bf_set_all()

Success Failures Total Runtime
2000 0 2000 06m:41s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for providing good unit test coverage :)

@maribu
Copy link
Member

maribu commented Nov 7, 2022

Given the low interconnection between the bitfield code and the remaining code, I think a 5 day old Murdock run is still good enough for this one.

@maribu maribu merged commit 7e0af3c into RIOT-OS:master Nov 7, 2022
@benpicco benpicco deleted the bitfield-ops branch November 7, 2022 19:27
@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants