CI: can_fast_ci_build.py unittests fix #18996
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR should fix #18987.
I first started with some sophisticated regex based generic replacement / mapping functionality, then decided to go simple...
The issue is that can_fast_ci_run.py correctly classifies any change to
tests/unittests/tests-$foo
to be a change to that module, but unittests are special in our build system - they can be built as one huge binary (tests/unittests
), or individually (tests/unittests/tests-*
). The latter are not built by CI and are not listed when doingmake info-applications
.Testing procedure
Issues/PRs references
Fixes #18987.