-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/tinyusb: add usb_board_reset support #19006
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modules `tinyusb_common` and `tinyusb_device` are enabled automatically when package `tinyusb` is used. There is no need to enable them manually.
gschorcht
requested review from
smlng,
leandrolanzieri,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
December 3, 2022 11:37
github-actions
bot
added
Area: pkg
Area: External package ports
Area: sys
Area: System
Area: tests
Area: tests and testing framework
labels
Dec 3, 2022
gschorcht
added
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
Type: enhancement
The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Dec 3, 2022
gschorcht
force-pushed
the
pkg/tinyusb_board_reset
branch
from
December 4, 2022 15:56
59e8ae8
to
d390b6c
Compare
benpicco
approved these changes
Dec 6, 2022
@benpicco Thanks for reviewing and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Kconfig
Area: Kconfig integration
Area: pkg
Area: External package ports
Area: sys
Area: System
Area: tests
Area: tests and testing framework
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
Type: enhancement
The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR provides tinyUSB support for module
usb_board_reset
whenstdio_tinyusb_cdc_acm
is used as stdio. The PR also provides some compilation fixes that occurred when addingusb_board_reset
support and that are needed for successful compilation. In detail:usb_board_rest
.NDEBUG
is defined.USB_VID
/USB_PID
are not defined.tests/pkg_tinyusb_cdc_msc/app.config.test
(out of scope of this PR but too small to fix as separate PR)Testing procedure
Use any board that provides the
tinyusb_device
feature, e.g. thestm32f429i_disc1
and flash:Once the USB port is recognized, execute
When using command
nothing should happen without commit 59e8ae8, but the board should restart with commit 59e8ae8. Without the other commits, the compilation fails completely.
Another example for testing would be:
When using command
the node restarts the application. With command
the node restarts in bootloader mode.
Issues/PRs references
Prerequisite for PR #18998