Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/rpi-pico-w: fix too large board image #19159

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

krzysztof-cabaj
Copy link
Contributor

@krzysztof-cabaj krzysztof-cabaj commented Jan 17, 2023

Contribution description

PR #19071 adds Raspberry Pico W board to RIOT. Unfortunately, current Doxygen version used for generation boards documentation available in RIOT webpage, do not scale images. In effect current documentation presents to users very, very huge board image. This PR change this image to smaller one, like in other boards.

Testing procedure

make doc
xdg-open doc/doxygen/html/group__boards__rpi__pico__w.htm

and compare with current documentation.

Issues/PRs references

PR #19071

@github-actions github-actions bot added Area: boards Area: Board ports Area: doc Area: Documentation labels Jan 17, 2023
@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jan 17, 2023
@riot-ci
Copy link

riot-ci commented Jan 17, 2023

Murdock results

✔️ PASSED

1ecdc10 boards/rpi-pico-w: fix too large board image

Success Failures Total Runtime
1 0 1 01m:04s

Artifacts

@aabadie
Copy link
Contributor

aabadie commented Jan 17, 2023

I confirm that this PR is improving the situation (see https://ci.riot-os.org/results/1c8978cdd053462a935bc50c88ba4ce8/doc-preview/group__boards__rpi__pico__w.html)

@aabadie
Copy link
Contributor

aabadie commented Jan 17, 2023

But not sure why the check-labels action is failing. Can you eventually rebase your branch on top of latest master (git pull --rebase origin master, assuming origin is the upstream remote) ?

@kaspar030
Copy link
Contributor

But not sure why the check-labels action is failing

the action is currently broken (since #19101), but also not required.

@krzysztof-cabaj
Copy link
Contributor Author

I rebased PR on top of current RIOT/master.

@aabadie aabadie added the Process: needs >1 ACK Integration Process: This PR requires more than one ACK label Jan 17, 2023
@benpicco benpicco removed the Process: needs >1 ACK Integration Process: This PR requires more than one ACK label Jan 18, 2023
@benpicco
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 18, 2023

Build succeeded:

@bors bors bot merged commit c7ded01 into RIOT-OS:master Jan 18, 2023
@jia200x jia200x added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants