Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/porting-boards.md: fix code snippets in md view #19206

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

krzysztof-cabaj
Copy link
Contributor

Contribution description

Current version of the file porting-boards.md did not present correctly in the github preview two snippets, presented in the sections: doc.txt and Using Common code.

This PR fix this issue.

Testing procedure

Check if these changes do not corrupt generated doxygen.

Issues/PRs references

None

@github-actions github-actions bot added the Area: doc Area: Documentation label Jan 27, 2023
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jan 29, 2023
@riot-ci
Copy link

riot-ci commented Jan 29, 2023

Murdock results

✔️ PASSED

9f0cf1c doc/porting-boards.md: fix code snippets in md view

Success Failures Total Runtime
1 0 1 53s

Artifacts

Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 29, 2023

Build succeeded:

@bors bors bot merged commit d187b2f into RIOT-OS:master Jan 29, 2023
bors bot added a commit that referenced this pull request Feb 1, 2023
19219: doc/porting-boards.md: fix code snippets in Riot web page/doxygen r=benpicco a=krzysztof-cabaj

### Contribution description

PR #19206 fix issues with code snippets in the[ `porting-boards.md`](https://github.com/RIOT-OS/RIOT/blob/master/doc/doxygen/src/porting-boards.md) presented by GitHub.  However, in Riot web page comments in code snippets are not presented and in effect section `doc.txt` shows empty area - see [dox.txt section](https://doc.riot-os.org/porting-boards.html). 

This PR should fix this - it change for this code snippet C code to generic code.  

### Testing procedure

Generation of doxygen documentation by CI process and manual check if this change fix the problem.

### Issues/PRs references

PR #19206

Co-authored-by: krzysztof-cabaj <kcabaj@gmail.com>
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants