doccheck: avoid generating dot or html #19228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: doc
kfessel
force-pushed
the
p-doccheck-fast
branch
2 times, most recently
from
54fe8ef
to
cc2afda
Compare
kfessel
force-pushed
the
p-doccheck-fast
branch
from
cc2afda
to
3de68c7
Compare
kfessel
added
the
CI: ready for build
that takes the option of just comparing the warnings master / PR. also the doccheck commit also modifies After |
|
otherwise, works as expected. and less warnings might be better. :) |
kaspar030
approved these changes
Jan 31, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jan 31, 2023
19228: doccheck: avoid generating dot or html r=kaspar030 a=kfessel ### Contribution description doccheck without generating dot or html this also has some new generated lines for exclude_pattern (some of them where broke so I regenerated the block) ### Testing procedure doccheck ### Issues/PRs references Co-authored-by: Karl Fessel <karl.fessel@ovgu.de>
|
Build failed: |
|
bors merge |
the patterns modified with the first commit where broken (opened groups without closing, used lists where they should not be used in exclude patterns and had unescaped the pattern added by the second commit is necessary for the check build target for that reason it is in the same commit.
i will have an other look at these (maybe some warning-errors are only happening when these are types of warnings that might be missed with the check build: de compact diff: de diff: |
|
these are types of warnings that might be missed with the check build: doxygen/doxygen#8071 and/or doxygen/doxygen#7706 seem related We can make these 3 types of warnings still show up if we generate html but disable dot. |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Feb 7, 2023
19240: tools/doccheck: add simple exclude to doccheck r=benpicco a=kfessel while doccheck runs for #19228 and #19220, i saw some spikes in memory consumption, turned out that was `grep -Evf dist/tools/doccheck/exclude_patterns` using about 2GB RAM. This PR changes that. ### Contribution description add `exclude_simple` to `doccheck` drived from `exclude patterns` `sort`ed and `uniq`ued the simple excludes removes no longer needed patterns from `exclude patterns` simple excludes are string rules (no patterns just strings) how to apply these: in this PR: *remove the path and line number from the rule * that made some of them doubles of each other * sorted and uniqued them. * this set of excludes is no longer path specific (an exception covers all paths but may of them still contain a file name) another possible solution would be to have the excludes line number specific. ### Testing procedure run `dist/tools/doccheck/check.sh` compare memory consumption of master: `grep -Evf dist/tools/doccheck/exclude_patterns` to this PR: `grep -Fvf dist/tools/doccheck/exclude_simple` ### Issues/PRs references 19248: cpu/gd32v: add periph_dac support r=benpicco a=gschorcht ### Contribution description This PR provides the `periph_dac` support for GD32VF103. ### Testing procedure `tests/periph_dac` should work on `sipeed-longan-nano` port on PA4 and PA5. ### Issues/PRs references 19255: boards/esp*: complete SD Card MTD config r=benpicco a=gschorcht ### Contribution description This PR provides the remaining changes necessary to use the generic MTD SD Card configuration as described in PR #19216. This includes defining the MTD offset for SD cards, since the default `MTD_0` device always uses the internal flash device, and the completion of the configuration for the ESP32 boards with a SD card interface. ### Testing procedure `tests/vfs_default` should work now with SD Cards: ``` main(): This is RIOT! (Version: 2023.04-devel-323-gfcc07) mount points: /nvm0 /sd0 data dir: /sd0 > vfs df Mountpoint Total Used Available Use% /nvm0 3052 KiB 8 KiB 3044 KiB 0% /sd0 7580 MiB 3632148992 B 21089792 B 99% ``` ### Issues/PRs references Co-authored-by: Karl Fessel <karl.fessel@ovgu.de> Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
doccheck without generating dot or html
this also has some new generated lines for exclude_pattern (some of them where broke so I regenerated the block)
Testing procedure
doccheck
Issues/PRs references